Fix for dataset and model variables Errors when downloading fairseq m… #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odels in the original implementation, the dataset and model variables were causing errors due to uninitialized in the TTS fairseq models. Changes Made: Introduced a line to split model_name into model_attributes based on the '/' delimiter. This ensures that the different components of the model name (language, dataset, model) can be separately and accurately accessed. Added lines to explicitly extract lang, dataset, and model from model_attributes using their respective indices. This change makes the code more robust and clear, as it directly links the variables to their sources: lang is now set to the second component (model_attributes[1]), dataset to the third (model_attributes[2]), model to the fourth (model_attributes[3]).
|
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…odels
in the original implementation, the dataset and model variables were causing errors due to uninitialized in the TTS fairseq models.
Changes Made:
Introduced a line to split model_name into model_attributes based on the '/' delimiter. This ensures that the different components of the model name (language, dataset, model) can be separately and accurately accessed. Added lines to explicitly extract lang, dataset, and model from model_attributes using their respective indices. This change makes the code more robust and clear, as it directly links the variables to their sources: lang is now set to the second component (model_attributes[1]), dataset to the third (model_attributes[2]),
model to the fourth (model_attributes[3]).