Push to ghcr #2
Merged
Push to ghcr #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
pr will use cache but will not update
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
reuben
reviewed
Oct 30, 2023
| @@ -31,7 +31,7 @@ jobs: | |||
| push: false # Do not push image for PR | |||
| cache-from: type=registry,ref=ghcr.io/coqui-ai/xtts-streaming-server:cache-pr-${{ github.event.pull_request.head.sha }} | |||
| cache-to: type=registry,ref=ghcr.io/coqui-ai/xtts-streaming-server:cache-pr-${{ github.event.pull_request.head.sha }} | |||
| tags: coqui-ai/xtts-streaming-server:${{ env.RELEASE_VERSION }}-${{ github.sha }} | |||
| tags: coqui-ai/xtts-streaming-server:pr-${{ github.event.pull_request.head.sha }} | |||
There was a problem hiding this comment.
Should remove the tags: input here (since we're not pushing) and use the PR number instead of HEAD commit hash in the cache lines above, as it changes on every push, breaking the caching.
There was a problem hiding this comment.
actually it is getting pr.head so always first one but ok
There was a problem hiding this comment.
HEAD is the latest, not the first
reuben
reviewed
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.