Bug fix in lambda-secrerlayer [CDS-1486] #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lambdas with nodejs20
royfur
approved these changes
Aug 25, 2024
ryantanjunming
pushed a commit
that referenced
this pull request
Oct 11, 2024
…lambdas with nodejs20 (#154) Signed-off-by: Ryan Tan <[email protected]>
ryantanjunming
added a commit
that referenced
this pull request
Oct 11, 2024
* change layer code to use nodejs18 code instead of 16 when running on lambdas with nodejs20 (#154) Signed-off-by: Ryan Tan <[email protected]> * resource type filter & AP3 region Signed-off-by: Ryan Tan <[email protected]> * IAM conditioning Signed-off-by: Ryan Tan <[email protected]> * sam validate fix, changed key Signed-off-by: Ryan Tan <[email protected]> * fix invocation comment * boolean correction * set boolean as strings instead * Revert "change layer code to use nodejs18 code instead of 16 when running on lambdas with nodejs20 (#154)" This reverts commit 4219206. --------- Signed-off-by: Ryan Tan <[email protected]> Co-authored-by: guyrenny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change layer code to use nodejs18 code instead of 16 when running in lambdas with nodejs20
Description
Fixes #How Has This Been Tested?
Checklist: