-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linked Accounts Metrics #180
Conversation
jakeskyaws seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I can see |
Thanks for the PR @jakeskyaws There seems to be an issue with your commits preventing them from being properly recognized as signed. Please insure that *all commits associated with this PR have been signed. This commit has not been signed. Also, insure to add the email address used for this commit to your account. |
* add ap3 region to integration, and add output to msk-data-stream integration * add entry to changelog
… Url & AP3 region changes (#175) * main changes added * wrong variable * AP3 readme * update variables description * domain naming and fixes * changelog and readme * more readme * example files * fix issue with tests * change private_key to api_key in firehose-logs test * fix readme and descriptions * update changelog --------- Co-authored-by: guyrenny <[email protected]>
Hi Shaun,
Thanks for the heads up. I’ve learned something new about verifying commit messages!
Jake Kudiersky
AWS Professional Services
DevOps Consultant
E: ***@***.******@***.***> | M: +44 7 881 848 408
[AWS re/Start Graduate][AWS Learning: Serverless][AWS Certified Security – Specialty][AWS Knowledge: Amazon EKS badge image. Learning. Issued by Amazon Web Services Training and Certification]
Thoughts on our interaction, provide feedback here<https://feedback.aws.amazon.com/?ea=jakesky&fn=Jake&ln=Kudiersky>
From: Shaun Remekie ***@***.***>
Reply to: coralogix/terraform-coralogix-aws ***@***.***>
Date: Tuesday 8 October 2024 at 11:13
To: coralogix/terraform-coralogix-aws ***@***.***>
Cc: Jake Kudiersky ***@***.***>, Mention ***@***.***>
Subject: Re: [coralogix/terraform-coralogix-aws] Linked Accounts Metrics (PR #180)
Thanks for the PR @jakeskyaws<https://github.com/jakeskyaws>
There seems to be an issue with your commits preventing them from being properly recognized as signed.
Please insure that *all commits associated with this PR have been signed. This commit<5d7c6fe> has not been signed.
Also, insure to add the email address used for this commit to your account<https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user>.
—
Reply to this email directly, view it on GitHub<#180 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3VYP4QVA44XPYRWNI7SBM3Z2OV4HAVCNFSM6AAAAABO2VFWRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJZGQZTOMJSGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA Sarl, UK Branch, 1 Principal Place, Worship Street, London, EC2A 2FA, United Kingdom, registered in England and Wales, UK Establishment No. BR019315
|
Summary of Changes
New Variable for Linked Accounts Metrics:
include_linked_accounts_metrics
is added. This variable allows the inclusion of metrics from linked source accounts when creating a metric stream in a monitoring account. It defaults tofalse
.Additional Parameters for Metric Streams:
include_linked_accounts_metrics
is added toaws_cloudwatch_metric_stream
, enabling users to specify whether to include metrics from linked accounts.Enhancements to Existing Variables:
include_metric_stream_namespaces
,include_metric_stream_filter
, andadditional_metric_statistics_enable
are retained and clarified. Theadditional_metric_statistics_enable
boolean variable controls the inclusion of additional statistics in the streamed metrics.Changes to Terraform Files:
main.tf
andvariables.tf
include variables and configurations for linked account metrics, along with modifications toaws_cloudwatch_metric_stream
.README Update: