Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new variables to shipper module [CDS-1696] #185

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

guyrenny
Copy link
Contributor

Description

Add new variables: reserved_concurrent_executions, execution_role_name and lambda_assume_role_arn
Removed the policy from the lambda module and created it with a different resource

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from a team as a code owner November 25, 2024 07:42
@guyrenny guyrenny force-pushed the assumrole-shipper-update branch from d5aeb37 to cd46c9a Compare November 26, 2024 13:50
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyrenny guyrenny merged commit 13f6c92 into master Nov 26, 2024
6 checks passed
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants