Updating to allow for multiple log watch in the same S3 bucket.

[badcure]

Description

The goal is to allow for multiple log watching on S3 buckets. There were a lot of conflicting resources, between lambdas and S3 file notifications, that only allowed for one log watch in a Terraform instance.

This changes allows for multiple log watches in a single S3 bucket, and allows for multiple modules to be used in the same project.

The config that I have working now looks like this

module "coralogix-cloudtrail-main" {
  source           = "github.com/<name>/terraform-coralogix-aws//modules/s3"
  coralogix_region = "US2"
  private_key      = data.aws_ssm_parameter.coralogix_api_key.value
  log_info         = {
    "cloudtrail-main" = {
      application_name = "everyonesocial-${var.environment}-cloudtrail"
      subsystem_name   = "cloudtrail-main"
      integration_type = "cloudtrail"
    }
  }
  s3_bucket_name = data.aws_ssm_parameter.cloudtrail.value
}

module "coralogix-cloudfront" {
  source           = "github.com/<name>/terraform-coralogix-aws//modules/s3"
  coralogix_region = "US2"
  private_key      = data.aws_ssm_parameter.coralogix_api_key.value
  s3_bucket_name   = data.aws_ssm_parameter.cflogs.value
  log_info = {
    "cloudfront-main" = {
      application_name = "everyonesocial-${var.environment}-cloudfront"
      subsystem_name   = "cloudfront-main"
      integration_type = "s3"
      s3_key_prefix    = "${data.aws_ssm_parameter.everyonesocial_domain.value}/"
    }
    "cloudfront-api" = {
      application_name = "everyonesocial-${var.environment}-cloudfront"
        subsystem_name   = "cloudfront-api"
        integration_type = "s3"
        s3_key_prefix    = "${data.aws_ssm_parameter.everyonesocial_api_domain.value}/"
    }
  }
}

How Has This Been Tested?

I am running this now, and running terraform again says 0 changes where before there were changes each time:
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Checklist:

• I have updated the relevant example in the examples directory for the module.
• I have updated the relevant test file for the module.
• This change does not affect module (e.g. it's readme file change)

[guyrenny]

Hey @badcure, thank you for the PR and for informing us of the problem. Because its a big change it will take some time and would like to implement it for our next sprint.
For now, i got 2 points:

1. In case you update a module you also need to update the CHANGELOG file that is relevant to the module so that the change will be documented.
2. Run terraform fmt for the files there is some misplaced indentions that i saw.

[badcure]

@guyrenny Done. for the S3 module, I made it a major version update since it seems like a breaking change.

That said, the goal is to allow multiple watches on the same bucket, and subsequent terraform runs be noop if there are no changes.

Let me know if you would like me to change anything else.

[github-actions]

🎉 This issue has been resolved in version 1.0.84 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀