Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove IAM role for EventBridge name default[CDS-605] #86

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Sep 6, 2023

Description

Add create_role = false so that a role named default will not be created, i checked and there is not need for him, and it could cause a conflict for customers that have a role with this name.

Fixes #

How Has This Been Tested?

Ran the integration without the role and i saw that i am still getting metadata to my coralogix account.

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from royfur September 6, 2023 12:15
@guyrenny guyrenny requested a review from a team as a code owner September 6, 2023 12:15
@guyrenny guyrenny merged commit aed6b7c into master Sep 6, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🎉 This PR is included in version 1.0.56 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@guyrenny guyrenny deleted the resource-metadata-update branch October 2, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants