Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firehose metrics add subsystem, create override_default_tags #92

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

ryantanjunming
Copy link
Contributor

Description

  • Added subsystem value to common attributes of firehose metrics
  • Added override_default_tags to allow users to override the default tags we set

How Has This Been Tested?

Local testing with our AWS account

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@macmiranda
Copy link

Hey @ryantanjunming just an idea, perhaps var.override_default_tags should be a boolean. var.user_supplied_tags remains the variable for user input. The former just changes the behavior of the merge. If true, the user-supplied tags come later in the merge, if false the other way around (which is the default).

Having two maps for user-supplied tags will be confusing.

@ryantanjunming
Copy link
Contributor Author

@macmiranda i'll set it as var.use_default_tags boolean default to true. If false, it will remove the default tags and leave just the var.user_supplied_tags.

So it's possible to have it empty also.

@macmiranda macmiranda mentioned this pull request Oct 3, 2023
3 tasks
modules/firehose/README.md Outdated Show resolved Hide resolved
modules/firehose/variables.tf Outdated Show resolved Hide resolved
@ryantanjunming ryantanjunming merged commit 279610e into master Oct 4, 2023
9 checks passed
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

🎉 This PR is included in version 1.0.58 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ryantanjunming ryantanjunming deleted the firehose-metrics-subsystem branch November 15, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants