-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORL-3213] premoderate and ban aliased email addresses under certain conditions #4744
Conversation
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I left a few small comments/questions throughout. I did also get an error when trying to enable the new config and clicking save changes
, so haven't completed manual testing yet. The error is Cannot create field 'emailAliases' in element {premoderateEmailAddress: null}
...src/core/client/admin/routes/Configure/sections/Moderation/PremoderateEmailAddressConfig.tsx
Show resolved
Hide resolved
- refactored from the `/.../` notation and forgot to remove the outer `/` when putting as raw string into `RegExp` - also updated the local auth flow ban tests to also include the new alias ban flow if enabled
updated as per Tessa and Andrews conversations in Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall! Thank you for all the updates. I left a few comments throughout. The only blocking one is that I think we need a check for the premoderate email aliases feature being enabled before banning a user because other aliases are banned.
...src/core/client/admin/routes/Configure/sections/Moderation/PremoderateEmailAddressConfig.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, ty for the updates!
What does this PR do?
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
Adds premoderate email alias options to
Settings
configs.Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md
?N/A
How do I test this PR?
Config > Admin > Moderate
Were any tests migrated to React Testing Library?
No
How do we deploy this PR?
develop