-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filling variables struct to complete audit info #968
fix: filling variables struct to complete audit info #968
Conversation
Signed-off-by: Cristobal ARELLANO <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
==========================================
+ Coverage 82.71% 82.74% +0.02%
==========================================
Files 162 162
Lines 9062 9056 -6
==========================================
- Hits 7496 7493 -3
+ Misses 1317 1315 -2
+ Partials 249 248 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@CArellanoOrbik thanks for this! Could you please add a test for covering the change? |
Signed-off-by: Cristobal ARELLANO <[email protected]>
@jcchavezs I have just added two test, one for each fix :) |
Signed-off-by: Cristobal ARELLANO <[email protected]>
@jcchavezs I have accidentally clicked in "request review". Could you approve it? |
Make sure that you've checked the boxes below before you submit PR:
Thanks for your contribution ❤️