Skip to content

Commit

Permalink
Allow to skip ConfigMap creation
Browse files Browse the repository at this point in the history
There are cases where zones are different but plugins are. In order to
avoid duplication of whole zone block configuration, allow to disable
config map creation and let it to be managable externally, where it is
possible to keep plugins configuration same, but change zone definition
only.

Signed-off-by: Dinar Valeev <[email protected]>
  • Loading branch information
k0da committed Sep 22, 2021
1 parent 70519f7 commit 2cd36c9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/coredns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.16.3
version: 1.16.4
appVersion: 1.8.4
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand Down
4 changes: 3 additions & 1 deletion charts/coredns/templates/configmap.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{{- if .Values.deployment.enabled }}
{{- if .Values.deployment.enabled }}
{{- if not .Values.deployment.skipConfig }}
---
apiVersion: v1
kind: ConfigMap
Expand Down Expand Up @@ -34,3 +35,4 @@ data:
{{ .filename }}: {{ toYaml .contents | indent 4 }}
{{- end }}
{{- end }}
{{- end }}
1 change: 1 addition & 0 deletions charts/coredns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -297,5 +297,6 @@ autoscaler:
successThreshold: 1

deployment:
skipConfig: false
enabled: true
name: ""

0 comments on commit 2cd36c9

Please sign in to comment.