Merge pull request #148 from JT-IT/allow-defaultmode-override

Ability to override defaultMode for extraSecrets
coredns · Nov 2, 2023 · 61164fb · 61164fb
2 parents 737c658 + 1a54304
commit 61164fb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/charts/coredns/Chart.yaml b/charts/coredns/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: coredns
-version: 1.28.0
+version: 1.28.1
 appVersion: 1.11.1
 home: https://coredns.io
 icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
@@ -21,4 +21,4 @@ type: application
 annotations:
   artifacthub.io/changes: |
     - kind: added
-      description: topologySpreadConstraints can be templated values
+      description: Added option to override defaultMode for extraSecrets
diff --git a/charts/coredns/templates/deployment.yaml b/charts/coredns/templates/deployment.yaml
@@ -153,7 +153,7 @@ spec:
         - name: {{ .name }}
           secret:
             secretName: {{ .name }}
-            defaultMode: 400
+            defaultMode: {{ default 400 .defaultMode }}
 {{- end }}
 {{- if .Values.extraVolumes }}
 {{ toYaml .Values.extraVolumes | indent 8 }}

diff --git a/charts/coredns/values.yaml b/charts/coredns/values.yaml
@@ -246,8 +246,10 @@ extraVolumeMounts: []
 extraSecrets: []
 # - name: etcd-client-certs
 #   mountPath: /etc/coredns/tls/etcd
+#   defaultMode: 420
 # - name: some-fancy-secret
 #   mountPath: /etc/wherever
+#   defaultMode: 440
 
 # To support legacy deployments using CoreDNS with the "k8s-app: kube-dns" label selectors.
 # See https://github.com/coredns/helm/blob/master/charts/coredns/README.md#adopting-existing-coredns-resources