Skip to content

Commit

Permalink
Use image tag from chart.yaml by default (#106)
Browse files Browse the repository at this point in the history
Signed-off-by: Hagai Barel <[email protected]>
  • Loading branch information
hagaibarel authored Mar 30, 2023
1 parent 4a1c6d4 commit 701da6e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
10 changes: 8 additions & 2 deletions charts/coredns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: coredns
version: 1.19.10
version: 1.20.0
appVersion: 1.9.4
home: https://coredns.io
icon: https://coredns.io/images/CoreDNS_Colour_Horizontal.png
Expand All @@ -14,8 +14,14 @@ sources:
maintainers:
- name: mrueg
- name: haad
- name: HagaiBarel
engine: gotpl
type: application
annotations:
artifacthub.io/changes: |
- Initial helm chart changelog
- kind: changed
description: Use chart appVersion as default image tag
- kind: added
description: Add HagaiBarel as chart maintainer
- kind: fixed
description: Fix reference link to values file in the readme
2 changes: 1 addition & 1 deletion charts/coredns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ Alternatively, a YAML file that specifies the values for the above parameters ca
$ helm install coredns coredns/coredns -f values.yaml
```

> **Tip**: You can use the default [values.yaml](values.yaml)
> **Tip**: You can use the default [values.yaml](/charts/coredns/values.yaml)
## Caveats

Expand Down
2 changes: 1 addition & 1 deletion charts/coredns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ spec:
{{- end }}
containers:
- name: "coredns"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args: [ "-conf", "/etc/coredns/Corefile" ]
volumeMounts:
Expand Down
3 changes: 2 additions & 1 deletion charts/coredns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@

image:
repository: coredns/coredns
tag: "1.9.4"
# Overrides the image tag whose default is the chart appVersion.
tag: ""
pullPolicy: IfNotPresent
## Optionally specify an array of imagePullSecrets.
## Secrets must be manually created in the namespace.
Expand Down

0 comments on commit 701da6e

Please sign in to comment.