Support updating multiple EFIs in mirrored setups (RAID1) #813
Conversation
|
Skipping CI for Draft Pull Request. |
travier
changed the title
|
AFAIK, this is only for EFI setups and not BIOS ones. I don't know if we mirror the MBR as well for BIOS RAID setups in FCOS. |
I think you are right, let's skip BIOS first, can add it later if needed.
I think we support it. Run |
HuijingHei
force-pushed
the
multiple-efi
branch
from
2b522df to
e354c61
Compare
|
Acording to Hristo on the fcos channel, we do mirror the MBR for RAID mirror setups with BIOS. We can do that later as we mostly care about the UEFI case for now. |
HuijingHei
force-pushed
the
multiple-efi
branch
11 times, most recently
from
c4c6b1e to
33d1285
Compare
HuijingHei
force-pushed
the
multiple-efi
branch
from
33d1285 to
6276923
Compare
|
I only gave this a superficial skim, it seems sane (nice work!! and thank you for working on this!) but it's a big change and merits a deeper review. I will try to get some time. In the intermediate time, can you split off the first two prep commits to a separate PR? |
Update `get_bios_boot_partition()`: - Return None if has multiple devices (currently not supported)
Sure, the prep PR is #820, and will update this when the prep PR merged. |
The EFI System Partition is not mounted after booted, on systems configured with boot device mirroring, there are independent EFI partitions on each constituent disk, need to mount each disk and updates. But skip updating BIOS in this case. Xref to coreos#132
HuijingHei
force-pushed
the
multiple-efi
branch
from
6276923 to
624f424
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add blockdev.rs to parse block device
bios.rs: update some functions to use blockdev
get_device()get_bios_boot_partition()to use blockdevThe EFI System Partition is not mounted after booted, on systems
configured with boot device mirroring, there are independent EFI
partitions on each constituent disk, need to mount each disk and
updates. But skip updating BIOS in this case.
Xref to #132