qemu: Automatically inject serial console karg into ISO #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support injecting kernel arguments in the ISO, let's make use of it by default when booting a live ISO to inject the appropriate serial console karg. This is more convenient for manual testing (because one no longer has to interrupt the boot process to type it in), but also has the major advantage of ISO tests now being able to capture console output. In the future, we can also hook up the `--kargs` option to this.
|
Requires #1637 and coreos/coreos-installer#341 to get the benefits, but the code itself could be merged beforehand too (it'll just print a warning until the remaining pieces are in place). |
darkmuggle
approved these changes
Aug 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkmuggle, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we support injecting kernel arguments in the ISO, let's make
use of it by default when booting a live ISO to inject the appropriate
serial console karg. This is more convenient for manual testing (because
one no longer has to interrupt the boot process to type it in), but also
has the major advantage of ISO tests now being able to capture console
output.
In the future, we can also hook up the
--kargsoption to this.