Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35coreos-ignition: randomize partition GUIDs on first boot #1207

Closed
wants to merge 1 commit into from
Closed

35coreos-ignition: randomize partition GUIDs on first boot #1207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35coreos-ignition: randomize partition GUIDs on first boot 
We've been randomizing the disk GUID but not the partition GUIDs, contrary
to the GPT spec.  Partition GUIDs are already not stable identifiers,
since new ones are generated by create_disk.sh on every image build, so
ensure they're globally unique as well.

Randomizing the ESP GUID will break any existing UEFI boot variable
created by fallback.efi, so it's important that we only do this on the
first boot (to not break existing systems) and only after our bootloader
setup has been taught not to create boot variables (to not break new
systems).
  • Loading branch information
@bgilbert
bgilbert committed May 25, 2022
commit 0bc96b782af0f6a7427baedbe2b87b844b45c62a
2 changes: 1 addition & 1 deletion overlay.d/05core/usr/lib/dracut/modules.d/35coreos-ignition/coreos-gpt-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ if [ "${PTUUID:-}" != "$UNINITIALIZED_GUID" ]; then
fi

echo "Randomizing disk GUID"
sgdisk --disk-guid=R --move-second-header "$PKNAME"
sgdisk --randomize-guids --move-second-header "$PKNAME"
udevadm settle || :