[hold] Use new cosa build naming model #424
Conversation
coreos/coreos-assembler#1459 is going to add support for more convenient multiple builds. Here the `name` is derived simply from the name of the manifest file. We use the summary for cloud uploads, so that moves to `image.yaml`.
|
Pairs with coreos/coreos-assembler#1474 - don't merge until that merges. |
| @@ -0,0 +1,32 @@ | |||
| ref: fedora/${basearch}/coreos/testing-devel | |||
There was a problem hiding this comment.
Hmm, this is a bit awkward, because there is also a manifests/fedora-coreos.yaml. Maybe let's rename that one to reduce confusion?
This will also require updating config-bot, which right now special-cases manifest.yaml (see https://github.com/coreos/fedora-coreos-config#about-this-repo).
There was a problem hiding this comment.
Hmm, I wonder if it'd be simpler to just make coreos/coreos-assembler#1474 use a name field in image.yaml instead? It's not strictly correct since e.g. the OSTree tarball has that name too, though it does seem cleaner to have it be more explicit and sitting alongside summary.
|
Closing this out until we finalize the cosa model. |
tests/kola/misc-ro: backport kdump.service test
coreos/coreos-assembler#1459 is
going to add support for more convenient multiple builds.
Here the
nameis derived simply from the name of the manifest file.We use the summary for cloud uploads, so that moves to
image.yaml.