activation: allow more control over socket-activated file descriptors #441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XY of the problem is the fds indices used by systemd socket activation are left empty once
activation.Listener
is called. Any new fds typically take the lowest available fds, which means the expected socket-activated indices may be populated by other fds at any other point in the executing of the program.I'm creating a library that enables zero-downtime restarts by
execve
'ing the same program which requires that the fds be populated in the expected indices. This is not possible if another part of the program is using those fds.ConsumeFiles
the default and matches the previous logic - closes the systemd fds passed in.ReserveFiles
"reserves" the systemd fds by atomically replacing them with fds pointing at/dev/null
ConserveFiles
does nothing and keeps the systemd fds openunsetEnv
of the system