Skip to content

Commit

Permalink
libvm: set up ControlPath socket in /var/tmp
Browse files Browse the repository at this point in the history
It turns out there's a much smaller limit than PATH_MAX for Unix
sockets. On Linux, it's 108 characters. It took me some time to figure
out why `vmcheck` would sometimes fail depending on where the src
directory is and how ${topsrcdir} is defined. Let's just make things
safer by just using /var/tmp.

Closes: #949
Approved by: cgwalters
  • Loading branch information
jlebon authored and rh-atomic-bot committed Aug 24, 2017
1 parent b05b967 commit 2f6f8a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/common/libvm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ vm_setup() {
export VM=${VM:-vmcheck}
local sshopts="-o User=root \
-o ControlMaster=auto \
-o ControlPath=${topsrcdir}/ssh-$VM.sock \
-o ControlPath=/var/tmp/ssh-$VM-$(date +%s%N).sock \
-o ControlPersist=yes"

# If we're provided with an ssh-config, make sure we tell
Expand Down

0 comments on commit 2f6f8a9

Please sign in to comment.