Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join the Queue UI Updates (In Progress) #924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anchen9
Copy link
Collaborator

@anchen9 anchen9 commented Feb 9, 2025

Summary

Implement Lucy's redesign for the Join the Queue section including adjusting padding and adding markings to denote required fields. Add Files and Error State handling still in progress.

Screenshot 2025-02-09 at 2 29 41 AM Screenshot 2025-02-09 at 2 36 13 AM
  • Adjusted text sizes
  • Adjusted placeholder text
  • Edited padding/spacing
  • Added *Required to the top right and asteriks to every field
  • Began the portion for adding files (adding the svg for the button and making the container

Test Plan

  • inspect element to see if adjustments were made
  • **future notes about testing error-handling

Notes

  • working on implementing the error state & error handling
  • add file feature for the future?

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@anchen9 anchen9 requested a review from a team as a code owner February 9, 2025 07:35
@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 9, 2025

[diff-counting] Significant lines: 100.

Copy link
Contributor

@NIDHI2023 NIDHI2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! One note - I don't think the file part is required, so it doesn't need the asterisk. Also once you're done working on this PR (ik it's still in progress), make sure you attach screenshots of the before vs. after and the figma designs for future reference

<p className="text"><span className="required"> * </span>Required</p>
</div>
<div className="tagsMiniContainer">
<p className="header">Select a Category<span className="required"> * </span></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code is good. An optimization I would make is probably factor out the asterisk into a reusable component like const Asterisk = () => <span className="required"> * </span>;. This way we don't have to repetitively nest span tags inside another jsx element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants