Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Fixes to host code generator and HCL runtime #394

Merged
merged 3 commits into from
Sep 20, 2021
Merged

[Backend] Fixes to host code generator and HCL runtime #394

merged 3 commits into from
Sep 20, 2021

Conversation

hecmay
Copy link
Collaborator

@hecmay hecmay commented Jul 21, 2021 •
edited
Loading

@seanlatias
Copy link
Collaborator

Can you remove unrelated file changes?

@hecmay
Copy link
Collaborator Author

hecmay commented Jul 21, 2021

Can you remove unrelated file changes?

Done.

@seanlatias seanlatias changed the title [FIX] Fixes to host code generator and HCL runtime [Backend] Fixes to host code generator and HCL runtime Jul 21, 2021
@seanlatias
Copy link
Collaborator

Please add a test that echos the issue.

@seanlatias
Copy link
Collaborator

Also, I think it's fine you keep the changes for the platform importing issue.

@hecmay
Copy link
Collaborator Author

hecmay commented Jul 21, 2021

Please add a test that echos the issue.

Okay.

BTW, can I also include changes that are needed enable to local CI/CD in this PR? otherwise the test case would not pass on Circle CI, since it requires running through vitis.

@hecmay
Copy link
Collaborator Author

hecmay commented Jul 21, 2021

The HCL in master branch is still using inter-process shared memory to communicate with host program. I may also nee to change that to JSON.

@seanlatias
Copy link
Collaborator

For shared memory, we create a separate PR. For CI settings, you can check how we test for vivado right now. We just need to add an option for pytest. We don't need the hcl-develop tag.

@yn224
Copy link
Contributor

yn224 commented Sep 14, 2021

Can this PR be merged?

@hecmay
Copy link
Collaborator Author

hecmay commented Sep 15, 2021

@yn224 I will add some more test cases for the fix and request a review later. Hopefully it can be merged soon.

@hecmay hecmay requested a review from seanlatias September 20, 2021 00:22
@seanlatias seanlatias merged commit 07004ab into cornell-zhang:master Sep 20, 2021
zzzDavid pushed a commit to zzzDavid/heterocl that referenced this pull request Sep 30, 2021
@hecmay @zzzDavid
[Backend] Fixes to host code generator and HCL runtime (cornell-zhang…
24f81a9 
…#394)

* fix issue 391

* revert

* add test case
zzzDavid pushed a commit to zzzDavid/heterocl that referenced this pull request Sep 30, 2021
@hecmay @zzzDavid
[Backend] Fixes to host code generator and HCL runtime (cornell-zhang…
3d1273c 
…#394)

* fix issue 391

* revert

* add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlatias seanlatias seanlatias approved these changes

Assignees
No one assigned
Labels
Backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenCL Codegen Issue
3 participants
@hecmay @seanlatias @yn224