Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colorlut): use the correct colorlut index if there's multiple segmentations #1611

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Nov 22, 2024

Context

The segmentation rendering was defaulting to index 0 all the time for the color lut

CleanShot 2024-11-22 at 11 44 40

also fixes : #1604

Copy link

stackblitz bot commented Nov 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 7c61700
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6740bb039afcea00088e16bc
😎 Deploy Preview https://deploy-preview-1611--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi November 22, 2024 16:45
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit 106cb24 into main Nov 22, 2024
26 checks passed
@sedghi sedghi deleted the fix/colorLut branch January 22, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] colorLUIOrIndex in RepresentationPublicInput doesn't appear to work properly.
2 participants