This repository has been archived by the owner on May 16, 2023. It is now read-only.
Tan generation refactoring #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damirseit
requested review from
f11h,
jhagestedt,
kreincke and
ascheibal
as code owners
|
Hello @damirseit, in generel the approach is good. But I would like to ask you rework your PR to use DependencyInjection and not directly instantiate these services via constructor. Maybe it would be also possible to do this with @qualifier Annotation of the different implementations then the factory would not be needed. |
f11h
suggested changes
Apr 14, 2022
| "Unknown source of trust inside the appsession for the registration token"); | ||
| } | ||
|
|
||
| TanVerifierFactory tanVerifierFactory = new TanVerifierFactoryImpl(); |
There was a problem hiding this comment.
Hello @f11h ,
Thank you very much for your feedback! I appreciate it.
I have pushed the changes into the branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue described in the comments section of:
#61
@alstiefel @dfischer-tech @f11h @jhagestedt @mlaue-tech @mschulte-tsi @tence @kreincke @ascheibal @BugBuster1701