Skip to content

Commit

Permalink
Re-ordered HPA specification to have memory as the first item in the …
Browse files Browse the repository at this point in the history
…`spec.metrics` list. (#290)

Signed-off-by: Ryan Woods <n4monitoring@node4.co.uk>
  • Loading branch information
RyanW8 authored Dec 15, 2021
1 parent 118f8ad commit 9ae9740
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 12 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## master / unreleased
* [CHANGE] Use port number for prometheus port annotations. #288
* [CHANGE] Disable ingester startup probes by default. #286
* [CHANGE] Moved HPA memory specification to be the first item in the list. #284
* [FEATURE] Optionally manage cortex config as configmap. #280
* [ENHANCEMENT] Upgrade to Cortex v1.11.0 #272

Expand Down
8 changes: 4 additions & 4 deletions templates/distributor/distributor-hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ spec:
minReplicas: {{ .minReplicas }}
maxReplicas: {{ .maxReplicas }}
metrics:
{{- with .targetCPUUtilizationPercentage }}
{{- with .targetMemoryUtilizationPercentage }}
- type: Resource
resource:
name: cpu
name: memory
target:
type: Utilization
averageUtilization: {{ . }}
{{- end }}
{{- with .targetMemoryUtilizationPercentage }}
{{- with .targetCPUUtilizationPercentage }}
- type: Resource
resource:
name: memory
name: cpu
target:
type: Utilization
averageUtilization: {{ . }}
Expand Down
8 changes: 4 additions & 4 deletions templates/nginx/nginx-hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ spec:
minReplicas: {{ .minReplicas }}
maxReplicas: {{ .maxReplicas }}
metrics:
{{- with .targetCPUUtilizationPercentage }}
{{- with .targetMemoryUtilizationPercentage }}
- type: Resource
resource:
name: cpu
name: memory
target:
type: Utilization
averageUtilization: {{ . }}
{{- end }}
{{- with .targetMemoryUtilizationPercentage }}
{{- with .targetCPUUtilizationPercentage }}
- type: Resource
resource:
name: memory
name: cpu
target:
type: Utilization
averageUtilization: {{ . }}
Expand Down
8 changes: 4 additions & 4 deletions templates/querier/querier-hpa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@ spec:
minReplicas: {{ .minReplicas }}
maxReplicas: {{ .maxReplicas }}
metrics:
{{- with .targetCPUUtilizationPercentage }}
{{- with .targetMemoryUtilizationPercentage }}
- type: Resource
resource:
name: cpu
name: memory
target:
type: Utilization
averageUtilization: {{ . }}
{{- end }}
{{- with .targetMemoryUtilizationPercentage }}
{{- with .targetCPUUtilizationPercentage }}
- type: Resource
resource:
name: memory
name: cpu
target:
type: Utilization
averageUtilization: {{ . }}
Expand Down

0 comments on commit 9ae9740

Please sign in to comment.