Re-ordered HPA specification to have memory as the first item in the …

…`spec.metrics` list. (#290) Signed-off-by: Ryan Woods <n4monitoring@node4.co.uk>
cortexproject · Dec 15, 2021 · 9ae9740 · 9ae9740
1 parent 118f8ad
commit 9ae9740
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## master / unreleased
 * [CHANGE] Use port number for prometheus port annotations. #288
 * [CHANGE] Disable ingester startup probes by default. #286
+* [CHANGE] Moved HPA memory specification to be the first item in the list. #284
 * [FEATURE] Optionally manage cortex config as configmap. #280
 * [ENHANCEMENT] Upgrade to Cortex v1.11.0 #272
 

diff --git a/templates/distributor/distributor-hpa.yaml b/templates/distributor/distributor-hpa.yaml
@@ -15,18 +15,18 @@ spec:
   minReplicas: {{ .minReplicas }}
   maxReplicas: {{ .maxReplicas }}
   metrics:
-  {{- with .targetCPUUtilizationPercentage }}
+  {{- with .targetMemoryUtilizationPercentage }}
     - type: Resource
       resource:
-        name: cpu
+        name: memory
         target:
           type: Utilization
           averageUtilization: {{ . }}
   {{- end }}
-  {{- with .targetMemoryUtilizationPercentage }}
+  {{- with .targetCPUUtilizationPercentage }}
     - type: Resource
       resource:
-        name: memory
+        name: cpu
         target:
           type: Utilization
           averageUtilization: {{ . }}

diff --git a/templates/nginx/nginx-hpa.yaml b/templates/nginx/nginx-hpa.yaml
@@ -15,18 +15,18 @@ spec:
   minReplicas: {{ .minReplicas }}
   maxReplicas: {{ .maxReplicas }}
   metrics:
-  {{- with .targetCPUUtilizationPercentage }}
+  {{- with .targetMemoryUtilizationPercentage }}
     - type: Resource
       resource:
-        name: cpu
+        name: memory
         target:
           type: Utilization
           averageUtilization: {{ . }}
   {{- end }}
-  {{- with .targetMemoryUtilizationPercentage }}
+  {{- with .targetCPUUtilizationPercentage }}
     - type: Resource
       resource:
-        name: memory
+        name: cpu
         target:
           type: Utilization
           averageUtilization: {{ . }}

diff --git a/templates/querier/querier-hpa.yaml b/templates/querier/querier-hpa.yaml
@@ -15,18 +15,18 @@ spec:
   minReplicas: {{ .minReplicas }}
   maxReplicas: {{ .maxReplicas }}
   metrics:
-  {{- with .targetCPUUtilizationPercentage }}
+  {{- with .targetMemoryUtilizationPercentage }}
     - type: Resource
       resource:
-        name: cpu
+        name: memory
         target:
           type: Utilization
           averageUtilization: {{ . }}
   {{- end }}
-  {{- with .targetMemoryUtilizationPercentage }}
+  {{- with .targetCPUUtilizationPercentage }}
     - type: Resource
       resource:
-        name: memory
+        name: cpu
         target:
           type: Utilization
           averageUtilization: {{ . }}