Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply bytes limiter to LabelNames and LabelValuesForLabelNames #6568

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Apply bytes limiter to LabelNames and LabelValuesForLabelNames #6568

merged 6 commits into from
Feb 3, 2025

Conversation

justinjung04
Copy link
Contributor

@justinjung04 justinjung04 commented Jan 31, 2025 •
edited
Loading

What this PR does:

This PR is

  1. Apply bytes limiter to Distributor.LabelNames and Distributor.LabelValuesForLabelNames functions, and
  2. Fix a bug in Distributor.MetricsForLabelMatchersStream where bytes limiter was overwriting the error from the stream response

Which issue(s) this PR fixes:
N/A

Checklist

  • [N/A] Tests updated
  • [N/A] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@justinjung04 justinjung04 changed the title Labels bytes limit Apply bytes limiter to LabelNames and LabelValues Jan 31, 2025
@justinjung04 justinjung04 changed the title Apply bytes limiter to LabelNames and LabelValues Apply bytes limiter to LabelNames and LabelValuesForLabelNames Jan 31, 2025
@justinjung04
changelog
749068a 
Signed-off-by: Justin Jung <[email protected]>
@justinjung04 justinjung04 marked this pull request as ready for review January 31, 2025 05:09
harry671003
harry671003 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@harry671003 harry671003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

yeya24
yeya24 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just need to fix conflict

@yeya24 yeya24 merged commit e8b8f90 into cortexproject:master Feb 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry671003 harry671003 harry671003 approved these changes

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
component/distributor size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinjung04 @harry671003 @yeya24