adjustment: refactor AppJs to Hooks #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cory2067
requested changes
Mar 5, 2022
client/src/components/App.js
Outdated
| }; | ||
|
|
||
| setLoginAttention = (value) => { | ||
| this.setState({ loginAttention: value }); | ||
| const toggleLoginAttention = (value) => { |
There was a problem hiding this comment.
i dont think we need updateUser or toggleLoginAttention anymore, since they're equivalent to setUser and setLoginAttention respectively
can we delete these functions, and directly pass setUser and setLoginAttention to the components below?
There was a problem hiding this comment.
Currently has errors, trying to aswell convert affected components now to Hooks.
package-lock.json
Outdated
| @@ -1,8 +1,12797 @@ | |||
| { | |||
| "name": "gtsosu", | |||
| "version": "1.0.0", | |||
| "lockfileVersion": 1, | |||
| "lockfileVersion": 2, | |||
There was a problem hiding this comment.
can you un-commit package-lock.json for now? we talked about this in the dev channel, and i wanna get our node versioning etc. sorted out and then i'll update package-lock in a separate commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #37 to refactor current state of the site, to migrate from Class Component based to use React Hooks
Files Changed: