Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacecraft file tutorial #149

Merged
merged 21 commits into from
Mar 18, 2024
Merged

Spacecraft file tutorial #149

merged 21 commits into from
Mar 18, 2024

Conversation

israelmcmc
Copy link
Collaborator

@israelmcmc israelmcmc commented Feb 29, 2024 •
edited
Loading

Closed #147

I'll track my changes here to coordinate with @Yong2Sheng

  • Changed the name of the nb
  • Removed mention of deprecated formats. We only use the .ori files right now.
  • I merged all of @Yong2Sheng commits from Add the point source response content to the DetectorResponse notebook #150
  • @Yong2Sheng : good ideas to get the unique pixels during the dwell time map calculation! That inspired me to update a few lines to make it even faster!
  • dts in SpacecraftFile is time a TimeDelta object, not Time (as it should).
  • I did a general overhaul of the SpacecraftFile and DetectorResponse tutorials. I added information, better plots, reorganized the text, etc.

israelmcmc and others added 18 commits February 29, 2024 16:19
@israelmcmc
Change name
e4f19a7
@Yong2Sheng
Added the point source response part to the DetectorResponse notebook…
544b03d 
…; Added the ori file for CgyX1; Deleted the npy files for CygX1 (they are replaced by the new .ori file)
@Yong2Sheng
Some text changes to the notebook.
b0bdf46
@israelmcmc
Merge remote-tracking branch 'Yong2Sheng/fast_ts_map_galactic' into s…
1253b94 
…catt_map_docs
@Yong2Sheng
Using DC2 orientation file to generate point source response
84d13c7
@Yong2Sheng
Accelerate the calculation of dwell time map.
8158f6e
@Yong2Sheng
Replace the old get_dwell_map with the new one. The function name is …
65e4c38 
…the same, so it will be effective for other codes that used the old one.
@Yong2Sheng
Add and update doc strings
3b78b4c
@Yong2Sheng
Merge branch 'cositools:main' into fast_ts_map_galactic
107a9f1
@israelmcmc
Merge remote-tracking branch 'Yong2Sheng/fast_ts_map_galactic' into s…
552c28d 
…catt_map_docs
@israelmcmc
Allow both string and Path objects
17ff708
@israelmcmc
Merge branch 'wasabi_pathlib' into scatt_map_docs
c1f9139
@israelmcmc
SC file tutorial overhaul
1806f2e
@israelmcmc
Response tutorial overhaul
1edae99
@israelmcmc
Use broadcasting and list comprehension to make the dwell time map ca…
8070c63 
…lculation faster
@israelmcmc
More optimizations, better handle of units
acd8853
@israelmcmc
Make sure dts is TimeDelta, not Time.
6821dcc
@israelmcmc
Update tutorials
d87552d
@israelmcmc israelmcmc requested a review from Yong2Sheng March 13, 2024 03:22
@israelmcmc
Copy link
Collaborator Author

@Yong2Sheng Can you please check and merge this PR? In particular, that both tutorials work, that I didn't remove any information you wanted, and that SpacecraftFile.py still works well.

@israelmcmc israelmcmc marked this pull request as ready for review March 13, 2024 13:33
@Yong2Sheng
Copy link
Contributor

Hi @israelmcmc,

I reviewed the PR, it looks great! I really like your algorithm to get the summed pixel durations.

I tested DetectorResponse.ipynb and SpacecraftFile.ipynb. They both ran very well.

I only have one minor comment on one line I posted above.

Thank you very much!

@israelmcmc
Merge pull request #2 from Yong2Sheng/scatt_map_docs
9f2a345 
Update the TS map tutorial notebook to avoide conflicts
@israelmcmc
Copy link
Collaborator Author

Note: all commits from PR #150 were merged here.

@israelmcmc israelmcmc mentioned this pull request Mar 18, 2024
Closed
Yong2Sheng
Yong2Sheng approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Yong2Sheng Yong2Sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@israelmcmc
Copy link
Collaborator Author

Thanks @Yong2Sheng, I'll merge it

@israelmcmc israelmcmc merged commit 47dd32f into cositools:main Mar 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yong2Sheng Yong2Sheng Yong2Sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@israelmcmc @Yong2Sheng