Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation link and only print one log-likelihood warning #151

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

eneights
Copy link
Contributor

@eneights eneights commented Mar 1, 2024

Updated index.rst to fix link to GRB spectral fitting notebook.

Updated COSILike and spectral fitting notebooks to only print one warning about the log-likelihood per fit. This is to avoid having the same warning printed repeatedly every time the log-likelihood is calculated in the example notebooks and documentation.

@eneights eneights requested review from israelmcmc and ckarwin March 1, 2024 17:12
@ckarwin
Copy link
Contributor

ckarwin commented Mar 4, 2024

Very nice @eneights! I ran through the GRB notebook and it works well. I also applied these changes to the extended source NB, in order to prevent unwanted output (Eliza added this to her PR). Note that for the extended source NB with multiple sources, there is a bunch of additional output from 3ML pertaining to the updated log values at each iteration of the fit. In order to silence this I also used the following right before the fit cell:

from threeML import update_logging_level
update_logging_level("CRITICAL")

Now the spectral fit NBs no longer have tons of output from the fit, which will make the tutorials much nicer and easier to read.

@ckarwin ckarwin merged commit f8a8518 into cositools:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants