Modified Example Notebooks with new ori file

[ckarwin]

I updated the spectral fit example notebooks (crab, GRB, and extended) with the new ori file, in order to be compatible with the recent changes to the SpacecraftFile class. The new ori file is the DC2 ori file which also includes the orbital information. It can be found here: https://s3.us-west-1.wasabisys.com/cosi-pipeline-public/COSI-SMEX/DC2/Data/Orientation/20280301_3_month_with_orbital_info.ori.

I also needed to update COSILike, since the scattmap now requires passing the source location. Lastly, I added an option in the scattmap calculation (and COSILike) to include the Earth occultation, with the default set to true.

This PR resolves issues #260 #262 and partially #263 (the other notebooks will also need to be updated, which I leave to the respective owners).

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.86%. Comparing base (f71e55d) to head (5b693b5).
Report is 15 commits behind head on develop.

Files with missing lines	Patch %	Lines
cosipy/threeml/COSILike.py	75.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
cosipy/spacecraftfile/SpacecraftFile.py	90.94% <100.00%> (+2.72%)	⬆️
cosipy/threeml/COSILike.py	70.44% <75.00%> (+1.45%)	⬆️

[ckarwin]

@hirokiyoneda This is ready for review when you have time.

[ckarwin]

@hirokiyoneda Ok, I needed to update the unit test coverage for additional lines I added, but all tests are now passing.

@eneights I recently merged your PR #256, but then soon realized it wasn't in the right place. It was in a directory called "spectral_fits", but it's better to be in the threeml directory, since that is the class it is testing. I moved it to the right place as part of this PR, and so there is nothing for you to do, but please be aware.

[hiyoneda]

I am running the notebooks, and found a quick mistake. The 3rd cell in `SpectralFit_Crab.ipynb' is:

fetch_wasabi_file('COSI-SMEX/DC2/Data/Orientation/20280301_3_month_with_orbital_info.ori', output=str(data_path / '20280301_3_month_modified.ori'))

Should it be data_path / '20280301_3_month_with_orbital_info.ori'?

[ckarwin]

@hiyoneda Yes, sorry, it's fixed now.

[hiyoneda]

Thanks! I am leaving my office, and the new orientation file is still being downloaded. I'll check it tomorrow morning here.

[ckarwin]

Ok, thank you!

[hiyoneda]

I confirmed that the new orientation file worked well without any errors, but I encountered the following error on the GRB notebook. I think that the binned event file is in the old format and does not have coordsys in PsiChi axis. Do you think that it is easy to fix it? (If not, I can merge this PR and make a new issue).

[ckarwin]

@hiyoneda Thanks for double checking. I ran through all three notebooks before making a PR to make sure everything was working, including the GRB notebook, and I didn't have this same issue. As part of this I downloaded all the files from scratch using the fetch_wasabi commands in the notebook. I just ran the GRB notebook again and it works fine for me. Can you double check that you are using the correct files and that they were downloaded ok?

[hiyoneda]

I used old files I previously downloaded, sorry. After downloading the new ones, everything worked well. Now we can merge this!

[ckarwin]

Ok, no problem. Thanks again.