Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change np.int16 to np.uint32 in the response file reading #276

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

GallegoSav
Copy link
Contributor

Pascal noticed using np.int16 could lead to negative value in the response matrices if the bincontent become to large. So I change to uint32 in order to be safe

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (3408ef9) to head (9a364ac).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
cosipy/response/FullDetectorResponse.py 0.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
cosipy/response/FullDetectorResponse.py 39.29% <0.00%> (ø)

@GallegoSav GallegoSav linked an issue Jan 6, 2025 that may be closed by this pull request
@israelmcmc
Copy link
Collaborator

Thanks @GallegoSav and @scipascal . Given the nature of the change --simple, contained, and with no new code--- I'll bypass the coverage requirements and merge this.

@israelmcmc israelmcmc merged commit e9bf11e into cositools:develop Jan 6, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change np.int16 to np.uint32 in the response file reading
2 participants