-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweeps #22
Conversation
@ayulockin I managed to produce some results. Please review the code. Things I am unsure of:
|
I think there is an error.(ERROR - Detected 5 failed runs in a row, shutting down) |
I coded keeping the |
First thing first, we will have to remove the code from #21 from this PR. |
You have admin access now, you can delete the runs/sweeps/artifacts. |
Will this example work while using FLAGS? |
I don't know actually. |
wandb.config resolved for sweeps to work as given in the documentaion and this example
|
Now, the issue to resolve is to fix the sweeps config file so it can take the |
The recent commit resolves these issues. wandb.agent properly working with no errors. I have to remove FLAGS from the With this, I still have some questions:
|
can you share the sweep dashboard?
The agent will pick from epoch values assigned in the sweep_config.yaml. In your sweep yaml file you have [5, 10, etc]. |
@ayulockin Here is the sweep dashboard. |
This looks perfect. @cosmo3769 Sabash. |
If you think code refactoring is required, do it. |
Done. |
@ayulockin Should we merge this branch into master branch now or after fixing the wandb.Table logging everytime issue? |
int(tmp_df.label), | ||
int(np.argmax(evaluation[i], axis = 0)) | ||
) | ||
|
||
if wandb.run is not None: | ||
wandb.log({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do something like this to fix wandb.Table logging everytime issue?
if wandb.run is not None:
if self.args.train_config.use_validation_table_log:
wandb.log({
'val_eval_loss': val_eval_loss,
'val_top@1': val_top_1_acc,
'val_top@5': val_top_5_acc,
'val_table': validation_table
})
else:
wandb.log({
'val_eval_loss': val_eval_loss,
'val_top@1': val_top_1_acc,
'val_top@5': val_top_5_acc,
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do something like this to fix wandb.Table logging everytime issue?
Yes, it works.
- wandb.Table logging everytime issue fixed.
@ayulockin Is there any other way to do it?
Work done:
|
I think the way you are doing sweep is correct. It's not working with I am merging the PR and we will fix the edge cased if we encounter (that we didn't so far) one PR at a time. :D |
Sweeps Code here. This is to resolve issue 23, issue 24, issue 20, issue 26.