Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v53 support, remove v52, fix scripts, etc #282

Merged
merged 13 commits into from
Apr 7, 2025

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Apr 2, 2025

fixes a bunch of issues with docs, removes 52, adds 53... etc

to run locally: yarn start. please have a look around the local website to verify.

@technicallyty technicallyty changed the title chore: add v53 fix: add v53 support, remove v52, fix scripts, etc Apr 3, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i may, i would adapt those two pages to 0.53 (basically removing some line about unexisting core apis), instead of reverting to 0.50. I took great care to improve the docs on runtime, which remained anyway the same in 0.50, 0.52 and 0.53 😅

This was explaining better what is runtime and how to use runtime: cosmos/cosmos-sdk#22816 / https://docs.cosmos.network/v0.52/build/building-apps/runtime

Happy to cherry-pick what's applicable if you want in the SDK directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the review didn't point the pages 😅. I meant this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and adding a runtime explainer like in the pr i linked in between those two.

@technicallyty
Copy link
Contributor Author

If i may, i would adapt those two pages to 0.53 (basically removing some line about unexisting core apis), instead of reverting to 0.50. I took great care to improve the docs on runtime, which remained anyway the same in 0.50, 0.52 and 0.53 😅

This was explaining better what is runtime and how to use runtime: cosmos/cosmos-sdk#22816 / https://docs.cosmos.network/v0.52/build/building-apps/runtime

Happy to cherry-pick what's applicable if you want in the SDK directly.

sure, runtime doc would be great! feel free to open a PR and ping me, i will take a look!

@technicallyty technicallyty merged commit 67c3381 into main Apr 7, 2025
1 check passed
@technicallyty technicallyty deleted the technicallyty/v53 branch April 7, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants