-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add v53 support, remove v52, fix scripts, etc #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i may, i would adapt those two pages to 0.53 (basically removing some line about unexisting core apis), instead of reverting to 0.50. I took great care to improve the docs on runtime, which remained anyway the same in 0.50, 0.52 and 0.53 😅
This was explaining better what is runtime and how to use runtime: cosmos/cosmos-sdk#22816 / https://docs.cosmos.network/v0.52/build/building-apps/runtime
Happy to cherry-pick what's applicable if you want in the SDK directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the review didn't point the pages 😅. I meant this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and adding a runtime explainer like in the pr i linked in between those two.
sure, runtime doc would be great! feel free to open a PR and ping me, i will take a look! |
fixes a bunch of issues with docs, removes 52, adds 53... etc
to run locally:
yarn start
. please have a look around the local website to verify.