Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cosmovisor): update simapp migration example #17583

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

fmorency
Copy link
Contributor

Description

Closes: #17582

This PR streamlines the cosmovisor simapp upgrade example to "just work" with the current and previous CosmosSDK versions.

This PR

  • removes references to legacy CosmosSDK versions
  • fixes genesis voting_period path
  • updates the CosmosSDK version used in the example
  • clarifies where to find the simdapp migration (name)
  • fixes link to the x/upgrade documentation
  • clarifies that the migration name given to cosmovisor must match the migration name defined in the migration plan

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the documentation writing guidelines
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct docs: prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR only changes documentation
  • reviewed content for consistency
  • reviewed content for thoroughness
  • reviewed content for spelling and grammar
  • tested instructions (if applicable)

@fmorency fmorency requested a review from a team as a code owner August 30, 2023 15:06
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 30, 2023
@github-prbot github-prbot requested review from a team, tac0turtle and samricotta and removed request for a team August 30, 2023 15:07
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Thank you!

@fmorency fmorency requested a review from julienrbrt August 30, 2023 17:36
@julienrbrt julienrbrt added this pull request to the merge queue Aug 30, 2023
Merged via the queue into cosmos:main with commit 914a8b6 Aug 30, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Streamline cosmovisor app upgrade example
2 participants