Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/staking): Use gogotypes Int64Value instead of bytes for LastValidatorPower #17604

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #XXXX

Here https://github.com/cosmos/cosmos-sdk/pull/17498/files#diff-b751d8b426a3bbcb08ccee5040c1eff9f0ec8d88bde9103506ae1bf8767d6b25R229, the collections map should not have a bytes value but an gogoproto.Int64Value

Initially posted by @testinginprod on slack channel


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review September 1, 2023 09:05
@likhita-809 likhita-809 requested a review from a team as a code owner September 1, 2023 09:05
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team September 1, 2023 09:05
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

x/staking/keeper/validator.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit eb85311 Sep 1, 2023
49 checks passed
@julienrbrt julienrbrt deleted the likhita/fix-LastValPower branch September 1, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants