Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accounts): Add message server and query server logic. #17614

Merged
merged 10 commits into from
Sep 7, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Sep 4, 2023

Description

Closes: #17615


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review September 4, 2023 13:25
@testinginprod testinginprod requested a review from a team as a code owner September 4, 2023 13:25
@github-prbot github-prbot requested review from a team, kocubinski and tac0turtle and removed request for a team September 4, 2023 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

@testinginprod your pull request is missing a changelog!

proto/cosmos/accounts/v1/tx.proto Outdated Show resolved Hide resolved
proto/cosmos/accounts/v1/tx.proto Show resolved Hide resolved
x/accounts/internal/implementation/api_builder.go Outdated Show resolved Hide resolved
x/accounts/internal/implementation/api_builder.go Outdated Show resolved Hide resolved
x/accounts/msg_server.go Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM, the api is simple to understand. Lets wait for another review prior to merging

@testinginprod testinginprod added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit c60283b Sep 7, 2023
51 of 52 checks passed
@testinginprod testinginprod deleted the tip/accounts/msg_query_server branch September 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(accounts): implement initial Query/MsgServer logic.
6 participants