Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: feedback on offset and count #17682

Closed
wants to merge 1 commit into from

Conversation

tac0turtle
Copy link
Member

Description

this pr is meant to seek feedback on the removal of count and offset.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle added S:blocked Status: Blocked S: DO NOT MERGE Status: DO NOT MERGE labels Sep 11, 2023
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the issue!
I am very happy that pagination is revisited again. From my experience offset/ count are not really needed or expected by people in modern web applications anymore. Therefore a strict focus on server side performance makes a lot of sense.

On a bigger picture, I can imagine different query implementations that use the same pagination request/ response object. Therefore the key or nextKey should not be defined as a storage key only but may contain other encoded query data as well.

@tac0turtle
Copy link
Member Author

talking to users it seems there are a lot of users of these. We should first provide an alternative before removing them. Ill open an issue

@tac0turtle tac0turtle closed this Sep 19, 2023
@tac0turtle tac0turtle deleted the marko/remove_offset_count branch April 17, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:blocked Status: Blocked S: DO NOT MERGE Status: DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants