Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/gov): extend governance config (backport #18428) #18445

Closed
wants to merge 6 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 10, 2023

This is an automatic backport of pull request #18428 done by Mergify.
Cherry-pick of 89296cc has failed:

On branch mergify/bp/release/v0.50.x/pr-18428
Your branch is up to date with 'origin/release/v0.50.x'.

You are currently cherry-picking commit 89296ccdd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/gov/README.md
	modified:   x/gov/keeper/msg_server_test.go
	modified:   x/gov/keeper/proposal.go
	modified:   x/gov/module.go
	modified:   x/gov/types/config.go
	modified:   x/gov/types/errors.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   api/cosmos/gov/module/v1/module.pulsar.go
	both modified:   proto/cosmos/gov/module/v1/module.proto
	deleted by us:   x/gov/go.mod
	deleted by us:   x/gov/go.sum
	both modified:   x/gov/keeper/keeper.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 89296cc)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/gov/module/v1/module.pulsar.go
#	proto/cosmos/gov/module/v1/module.proto
#	x/gov/go.mod
#	x/gov/go.sum
#	x/gov/keeper/keeper.go
@mergify mergify bot requested a review from a team as a code owner November 10, 2023 15:41
@mergify mergify bot added the conflicts label Nov 10, 2023
Copy link
Contributor

coderabbitai bot commented Nov 10, 2023

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-prbot github-prbot requested review from a team, alexanderbez and julienrbrt and removed request for a team November 10, 2023 15:41
@julienrbrt julienrbrt self-assigned this Nov 10, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) November 10, 2023 17:07
@tac0turtle
Copy link
Member

does this need to be backported?

@julienrbrt julienrbrt disabled auto-merge November 10, 2023 17:46
@julienrbrt
Copy link
Member

does this need to be backported?

This is a nice to have, does not per se need to be backported.

@julienrbrt
Copy link
Member

julienrbrt commented Nov 10, 2023

Re-read our release policy and let's not backport it unless strongly requested. It causes us trouble with the because of the api module.

@julienrbrt julienrbrt closed this Nov 10, 2023
@mergify mergify bot deleted the mergify/bp/release/v0.50.x/pr-18428 branch November 10, 2023 18:23
@julienrbrt julienrbrt removed their assignment Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants