build(all): bump core/testing to fc91e7635451 to remove golang/mock #22321
Conversation
islishude
requested review from
a team,
facundomedica,
testinginprod and
aaronc
as code owners
📝 WalkthroughWalkthroughThe pull request includes updates to multiple Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (3)
docs/build/building-modules/16-testing.md (2)
Line range hint
1-134: LGTM: Expanded Deterministic and Regression tests sectionThe addition of detailed information about testing queries with the
module_query_safeProtobuf annotation is valuable. It clearly explains the two methods used: property-based testing with therapidlibrary and regression tests.Suggestion: Consider adding a brief example or code snippet for the property-based testing method to complement the existing regression test example. This would provide a more balanced representation of both testing approaches.
Line range hint
134-134: LGTM: Added note about simulation refactoringThe addition of the note about simulations being refactored to message factories is valuable for keeping users informed about recent changes.
Suggestion: Consider expanding this note slightly to briefly explain the benefits or implications of this refactoring. This would provide more context for developers using the simulations.
x/authz/go.mod (1)
Unused Indirect Dependencies Identified
github.com/cockroachdb/fifogithub.com/google/uuidThese dependencies are not referenced in the codebase and may be unnecessary. Please verify if they are required or consider removing them to clean up the dependency tree.
🔗 Analysis chain
Line range hint
168-172: Verify new indirect dependenciesThree new indirect dependencies have been added:
- github.com/cockroachdb/fifo
- github.com/cosmos/cosmos-db
- github.com/google/uuid
Please confirm that these additions are necessary and don't introduce any conflicts or security issues. Consider running a dependency vulnerability check if not already part of your CI process.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for known vulnerabilities in the new dependencies # Test: Run go list to get more info about the new dependencies go list -m -json github.com/cockroachdb/[email protected] github.com/cosmos/[email protected] github.com/google/[email protected] # Test: Use Nancy to check for vulnerabilities (if available) if command -v nancy &> /dev/null; then go list -json -m all | nancy sleuth else echo "Nancy is not installed. Consider installing it for vulnerability scanning." fiLength of output: 424
Script:
#!/bin/bash # Description: Search the codebase for imports of new indirect dependencies # Define the dependencies to check dependencies=( "github.com/cockroachdb/fifo" "github.com/cosmos/cosmos-db" "github.com/google/uuid" ) # Iterate over each dependency and search for import statements for dep in "${dependencies[@]}"; do echo "Searching for imports of $dep..." rg "import\s+\"$dep\"" --type go done # Additionally, search for any references in the code for dep in "${dependencies[@]}"; do echo "Searching for references to $dep..." rg "$dep" --type go doneLength of output: 1894
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (33)
client/v2/go.sumis excluded by!**/*.sumcollections/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumorm/go.sumis excluded by!**/*.sumruntime/v2/go.sumis excluded by!**/*.sumserver/v2/cometbft/go.sumis excluded by!**/*.sumserver/v2/go.sumis excluded by!**/*.sumsimapp/go.sumis excluded by!**/*.sumsimapp/v2/go.sumis excluded by!**/*.sumstore/go.sumis excluded by!**/*.sumstore/v2/go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sumx/accounts/defaults/base/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.sumis excluded by!**/*.sumx/accounts/defaults/multisig/go.sumis excluded by!**/*.sumx/accounts/go.sumis excluded by!**/*.sumx/authz/go.sumis excluded by!**/*.sumx/bank/go.sumis excluded by!**/*.sumx/circuit/go.sumis excluded by!**/*.sumx/consensus/go.sumis excluded by!**/*.sumx/distribution/go.sumis excluded by!**/*.sumx/epochs/go.sumis excluded by!**/*.sumx/evidence/go.sumis excluded by!**/*.sumx/feegrant/go.sumis excluded by!**/*.sumx/gov/go.sumis excluded by!**/*.sumx/group/go.sumis excluded by!**/*.sumx/mint/go.sumis excluded by!**/*.sumx/nft/go.sumis excluded by!**/*.sumx/params/go.sumis excluded by!**/*.sumx/protocolpool/go.sumis excluded by!**/*.sumx/slashing/go.sumis excluded by!**/*.sumx/staking/go.sumis excluded by!**/*.sumx/upgrade/go.sumis excluded by!**/*.sum
📒 Files selected for processing (35)
- client/v2/go.mod (1 hunks)
- collections/go.mod (1 hunks)
- docs/build/building-modules/16-testing.md (1 hunks)
- go.mod (1 hunks)
- orm/go.mod (1 hunks)
- runtime/v2/go.mod (1 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- server/v2/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- store/go.mod (1 hunks)
- store/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- x/accounts/defaults/base/go.mod (1 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/ante/sigverify_test.go (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (12)
- client/v2/go.mod
- collections/go.mod
- simapp/go.mod
- store/v2/go.mod
- x/accounts/defaults/base/go.mod
- x/accounts/defaults/lockup/go.mod
- x/accounts/defaults/multisig/go.mod
- x/auth/ante/sigverify_test.go
- x/consensus/go.mod
- x/evidence/go.mod
- x/nft/go.mod
- x/upgrade/go.mod
🧰 Additional context used
📓 Path-based instructions (2)
docs/build/building-modules/16-testing.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
🔇 Additional comments (27)
store/go.mod (1)
7-7: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is consistent with the PR objectives and matches the commit hash mentioned in the PR summary. This change appears to be part of the effort to remove the golang/mock dependency.To ensure this change doesn't introduce any unexpected issues, please run the following command to verify that all tests pass with the updated dependency:
orm/go.mod (2)
7-7: LGTM. Verify compatibility with the new core version.The update of
cosmossdk.io/corefromv1.0.0-alpha.3tov1.0.0-alpha.4looks good. This minor version bump in an alpha release might introduce new features or bug fixes.Please ensure that this update doesn't introduce any breaking changes. Run the following command to check for any potential issues:
8-8: LGTM. Verify the intended changes in the new core/testing version.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This specific commit hash likely incorporates the changes related to removing the golang/mock dependency.To ensure that this update achieves the intended goal of removing golang/mock, please run the following commands:
If golang/mock is no longer present and no unexpected dependencies are introduced, the update has achieved its goal.
runtime/v2/go.mod (1)
33-33: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is in line with the PR's goal to bump the core/testing module. This change, along with the new indirect dependencies for protocol buffers, likely contributes to removing the golang/mock dependency as intended.To ensure the golang/mock dependency has been removed as a result of this update, please run the following script:
server/v2/go.mod (2)
Line range hint
46-46: Clarify the addition ofcosmossdk.io/errors/v2dependency.A new indirect dependency
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5has been added. Could you please provide more context on why this dependency was introduced?To better understand the impact of this new dependency, please run the following command:
#!/bin/bash # Description: Check for usage of the new errors package in the codebase # Test: Search for any imports or uses of cosmossdk.io/errors/v2 rg -i "cosmossdk.io/errors/v2"This will help us verify if the new package is being used directly in our codebase or if it's purely an indirect dependency.
17-17: Approve the update tocosmossdk.io/core/testing.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.Please ensure that this update doesn't introduce any breaking changes. Run the following command to check for any potential issues:
✅ Verification successful
Approve the update to
cosmossdk.io/core/testing.No breaking changes or deprecations were found in the updated version of
cosmossdk.io/core/testing. The dependency update is verified and safe to proceed.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any breaking changes or deprecations in the new version of cosmossdk.io/core/testing # Test: Search for any mentions of breaking changes or deprecations in the commit messages or changelogs rg -i "breaking change|deprecat" $(fd -t f -e md -e txt)Length of output: 62037
Script:
#!/bin/bash # Description: Check for any breaking changes or deprecations in the new version of cosmossdk.io/core/testing # Search for 'breaking change' or 'deprecations' specifically within the cosmossdk.io/core/testing module's CHANGELOG rg -i "breaking change|deprecation" $(fd -t f -e md -e txt cosmossdk.io/core/testing)Length of output: 42449
docs/build/building-modules/16-testing.md (3)
25-25: LGTM: Updated mockgen documentation linkThe link to the mockgen documentation has been correctly updated to
go.uber.org/mock. This change aligns with the PR objectives to migrate from the deprecated golang/mock to the maintained fork.
Line range hint
1-134: Verify changes in the Integration Tests sectionThe AI summary indicates that the Integration Tests section has been refined to clarify the distinction between integration tests and end-to-end tests. However, no specific line changes are highlighted in the provided diff. Please verify that these changes have been made correctly and that they accurately reflect the intended clarifications.
Line range hint
1-134: Verify changes in the System Tests sectionThe AI summary indicates that the System Tests section has been slightly rephrased to clarify the testing approach from a user perspective and to highlight the use of the
simappbinary. However, no specific line changes are highlighted in the provided diff. Please verify that these changes have been made correctly and that they effectively improve the clarity of the system testing approach.x/params/go.mod (1)
8-8: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives and is consistent with updates in other modules.To ensure consistency across the project, let's verify this update in other modules:
✅ Verification successful
Verified: All modules updated with the new core/testing version and no old versions remain.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the core/testing version update across all go.mod files # Test: Check for the new version in all go.mod files rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451' # Test: Ensure no old versions remain rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29'Length of output: 2896
x/staking/go.mod (1)
9-9: LGTM. Verify compatibility with the updated testing framework.The update of
cosmossdk.io/core/testingto a more recent version aligns with the PR objectives. This change likely introduces improvements or bug fixes to the testing framework.To ensure compatibility, please run the following verification script:
x/bank/go.mod (1)
33-33: LGTM. Verify consistency across modules.The update to
cosmossdk.io/core/testingis in line with the PR objectives. This change should help remove the dependency on golang/mock as intended.To ensure consistency, please run the following command to check if this version update has been applied uniformly across all relevant modules:
✅ Verification successful
Consistency Verified.
All instances of
cosmossdk.io/core/testinghave been updated to the specified version across relevant modules.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent version of cosmossdk.io/core/testing across all go.mod files grep -R "cosmossdk.io/core/testing" **/go.modLength of output: 576
x/protocolpool/go.mod (1)
9-9: LGTM: Version update for cosmossdk.io/core/testingThe update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives to update dependencies. This change is consistent with updates in other modules mentioned in the PR summary.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes or unexpected behavior in the protocolpool module. Consider running the module's test suite to confirm everything works as expected with the new version.
x/epochs/go.mod (1)
9-9: LGTM. Verify compatibility with the updated core/testing module.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objective. This change likely contributes to removing the golang/mock dependency.To ensure compatibility, please run the following command to check for any breaking changes or deprecations:
x/authz/go.mod (2)
166-166: LGTM: Core testing dependency updatedThe update of
cosmossdk.io/core/testingto the latest version (v0.0.0-20241021095809-fc91e7635451) aligns with the PR objectives and keeps the dependency up-to-date.
Line range hint
176-186: LGTM: Replace directives retainedThe replace directives for local development have been correctly retained. This is crucial for maintaining consistency across the Cosmos SDK ecosystem during local development and testing.
x/slashing/go.mod (1)
9-9: LGTM. Verify compatibility with the new core/testing version.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objective. This change should remove the dependency on golang/mock as intended.To ensure compatibility, please run the following command and verify that all tests pass:
x/circuit/go.mod (1)
9-9: LGTM: Dependency version update looks good.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes:
If any breaking changes are found, please ensure that the necessary adjustments have been made in the codebase.
x/distribution/go.mod (1)
9-9: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of bumping the core/testing version. This change is part of the effort to remove the golang/mock dependency.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes for other modules depending on
cosmossdk.io/x/distribution. You can run the following command to check for any potential issues:x/accounts/go.mod (1)
9-9: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of updating the core/testing module to remove the golang/mock dependency.To ensure this change doesn't introduce any unexpected dependencies, let's verify the module's dependencies:
x/mint/go.mod (2)
Line range hint
1-224: No other significant changes detected.The rest of the
go.modfile, including the replace directives, remains unchanged. This is consistent with the PR objectives, which focused specifically on updating the core/testing version to remove the golang/mock dependency.
9-9: LGTM: Version update for core/testing is consistent with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR's goal of bumping the core/testing version to remove the golang/mock dependency. This change is consistent with updates in other modules across the Cosmos SDK.To ensure consistency across all modules, let's verify this update in other
go.modfiles:✅ Verification successful
Verified: All go.mod files have consistent
core/testingversion.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of core/testing version across all go.mod files # Expected result: All go.mod files should have the same version for cosmossdk.io/core/testing echo "Checking core/testing version in all go.mod files:" find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} \; | sortLength of output: 3050
x/gov/go.mod (1)
9-9: LGTM: Dependency update aligns with PR objectives.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of updating the core/testing module. This change is part of a coordinated effort across multiple modules in the Cosmos SDK.To ensure consistency, let's verify that this version is used across all relevant modules:
✅ Verification successful
LGTM: Dependency version is consistently updated across all modules.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent use of core/testing version across modules # Expected: All occurrences should show the same version rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'Length of output: 2818
x/feegrant/go.mod (1)
9-9: Dependency version update looks good.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objective to bump the core/testing module. This change is consistent with the goal of removing the golang/mock dependency as mentioned in the PR summary.To ensure this change is consistent across the project, let's verify other
go.modfiles:✅ Verification successful
Dependency version consistent across all go.mod files.
The version
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451is consistently used across allgo.modfiles, ensuring alignment with the PR objective to updatecore/testingand remove thegolang/mockdependency.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the core/testing version is consistent across all go.mod files # Expected result: All go.mod files should have the same version of core/testing echo "Checking core/testing version across go.mod files:" find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} \;Length of output: 3043
server/v2/cometbft/go.mod (1)
46-46: LGTM: Core testing dependency updated as intended.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This precise version pinning is good for reproducibility.As this is an indirect dependency, please ensure that this update doesn't introduce any unexpected changes in the build process or tests. You can verify this by running:
go.mod (1)
9-9: LGTM. Verify compatibility with the updated core/testing module.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objective. This change, along with the removal ofgithub.com/golang/mock, successfully addresses the goal of updating the core/testing module and eliminating the golang/mock dependency.To ensure compatibility, please run the following command to verify that all tests pass with the updated dependency:
x/group/go.mod (1)
8-8: LGTM: Dependency update looks good.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the broader effort to update dependencies across multiple modules.To ensure compatibility, please verify that this update doesn't introduce any breaking changes or unexpected behavior in the
x/groupmodule. Consider running the module's test suite to confirm everything works as expected with the new dependency version.
| @@ -32,7 +32,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
cosmossdk.io/core/testing Update
The update to v0.0.0-20241021095809-fc91e7635451 introduces multiple deprecations and API breaking changes as outlined in the CHANGELOG.md. These changes may affect the stability and functionality of your tests.
-
Deprecations and Removals:
AppModuleBasicdeprecated for extension interfaces.- Removal of
clientCtx.PrintObjectLegacyin favor ofclientCtx.PrintProtoorclientCtx.PrintRaw. - Various deprecated functions and methods across modules (e.g.,
FromTmProtoPublicKey,ToTmProtoPublicKey,WithBlockTime).
-
API Breaking Changes:
- Significant changes in module configurations and parameter management.
- Renaming and removal of key functions and interfaces affecting module interactions.
Please review and address these breaking changes to ensure compatibility and stability within your test suite.
🔗 Analysis chain
LGTM: Version update aligns with PR objectives.
The update of cosmossdk.io/core/testing to v0.0.0-20241021095809-fc91e7635451 is in line with the PR's goal of updating the core/testing module. This pre-release version should allow testing against the latest changes.
To ensure stability, please run the following script to check for any breaking changes or issues introduced by this version update:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the new version of core/testing doesn't introduce breaking changes
# Test: Check if there are any compilation errors or test failures after the update
go test ./...
# Test: Look for any deprecation warnings or breaking change notices in the changelog
rg -i "deprecat|breaking change" CHANGELOG.md
Length of output: 13882
| @@ -58,7 +58,7 @@ require ( | |||
| cloud.google.com/go/iam v1.1.13 // indirect | |||
| cloud.google.com/go/storage v1.43.0 // indirect | |||
| cosmossdk.io/collections v0.4.0 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 // indirect | |||
There was a problem hiding this comment.
💡 Codebase verification
Issues Found: Deprecations Introduced by core/testing Module Update
The update of cosmossdk.io/core/testing has introduced numerous deprecated annotations across the codebase. These deprecations may lead to potential compatibility issues and suggest that further refactoring is necessary.
- Review and address deprecated usages in the following areas:
types/address.gotypes/module/*.gotypes/tx/*.gox/upgrade/types/*.go- And others as indicated in the verification output.
🔗 Analysis chain
LGTM: Version update for core/testing module
The update of cosmossdk.io/core/testing to the newer version v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change likely includes improvements or bug fixes.
To ensure compatibility, please run the following verification script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the updated core/testing module is compatible with the current codebase.
# Test: Check if there are any breaking changes or deprecations in the new version
rg -i "deprecated|breaking.?change" --type go
Length of output: 202625
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Outside diff range and nitpick comments (11)
store/go.mod (1)
Go version 1.23 in go.mod files is invalid and should be updated to a stable release.
- x/tx/go.mod
- tools/cosmovisor/go.mod
- tools/confix/go.mod
- store/go.mod
- store/v2/go.mod
- tests/systemtests/go.mod
- schema/testing/go.mod
- server/v2/go.mod
- runtime/v2/go.mod
- server/v2/stf/go.mod
- server/v2/appmanager/go.mod
- orm/go.mod
- indexer/postgres/tests/go.mod
- collections/go.mod
- core/testing/go.mod
- core/go.mod
🔗 Analysis chain
Line range hint
3-3: Verify the Go version specified.The
go.modfile specifies Go version 1.23, which is not yet released (as of April 2024). Please verify if this is intentional or if it should be updated to a current stable version.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the Go version specified in go.mod files across the repository # Test: Search for Go version declarations in go.mod files rg -g 'go.mod' '^go \d+\.\d+$'Length of output: 625
runtime/v2/go.mod (1)
golang/mock dependency still present
The
github.com/golang/mockdependency is still present as an indirect dependency intools/confix/go.mod. Please remove it to complete the migration togo.uber.org/mock.🔗 Analysis chain
Line range hint
1-85: Verify golang/mock removal and go.uber.org/mock addition in relevant modules.This module doesn't directly reference golang/mock or go.uber.org/mock. While this aligns with the goal of removing golang/mock, it's important to ensure the migration to go.uber.org/mock has been completed in other relevant modules.
Please run the following script to check the status of the migration across the project:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check the status of golang/mock removal and go.uber.org/mock addition echo "Checking for remaining golang/mock dependencies:" rg -i 'github.com/golang/mock' $(fd -t f -e go -e mod) echo "Checking for new go.uber.org/mock dependencies:" rg -i 'go.uber.org/mock' $(fd -t f -e go -e mod)Length of output: 190444
docs/build/building-modules/16-testing.md (3)
25-25: LGTM! Consider adding a brief explanation about the tool change.The URL update for the
mockgentool is correct and aligns with the PR objectives. This change reflects the migration from the deprecated golang/mock to the maintained fork by Uber.Consider adding a brief note explaining why the tool has changed, such as:
-You can read more about mockgen [here](https://go.uber.org/mock). +You can read more about mockgen [here](https://go.uber.org/mock). This is a maintained fork of the original golang/mock tool.
Line range hint
33-35: Consider updating code references to the latest version.The document contains references to
v0.50.0-alpha.0. To ensure the documentation remains current, consider updating these references to the latest stable version or using a more generic reference that doesn't require frequent updates.Also applies to: 83-85, 134-136
Line range hint
121-123: Expand on the note about simulations.The note about simulations being refactored to use message factories is brief and might benefit from additional context or explanation. Consider expanding this section to provide more details about the refactoring and its implications for testing.
For example:
:::note Simulations have been refactored to use message factories. This change improves the flexibility and maintainability of simulation tests by allowing for more modular and reusable message generation. :::x/params/go.mod (1)
Line range hint
160-172: Note: Temporary replace directives present.The file contains several replace directives marked with a TODO comment. While these are not directly related to the current change, it's worth noting for future maintenance. Consider creating a separate issue to track the removal of these replace directives once all modules have been spun out.
x/accounts/go.mod (1)
Line range hint
160-167: Consider addressing the TODO comment in replace directives.There's a TODO comment indicating that some replace directives should be removed after spinning out all modules. While this is not directly related to the current change, it might be worth tracking this task for future cleanup.
Would you like me to create a GitHub issue to track the task of removing these replace directives once all modules are spun out?
x/mint/go.mod (1)
Line range hint
165-174: Consider addressing the TODO comment and reviewing replace directives.There's a TODO comment regarding "spinning out all modules" and several replace directives for cosmossdk.io packages. While not directly related to the current change, it might be beneficial to:
- Address the TODO comment if the mentioned task has been completed or is no longer relevant.
- Review the replace directives to ensure they are still necessary and up-to-date.
This could help improve the module's structure and dependency management.
go.mod (1)
Line range hint
1-1: Consider additional steps for a smooth transition.Given the significance of these changes, please consider the following additional steps:
- Update all relevant documentation to reflect the new testing module version and the switch to
go.uber.org/mock.- Review and update any build scripts or CI/CD pipelines that might be affected by these changes.
- Communicate these changes to the wider development team to ensure everyone is aware of the new mocking framework.
- Consider creating a migration guide for any external projects that depend on the Cosmos SDK, to help them adapt to these changes.
Would you like assistance in drafting any of these additional materials or guides?
tests/go.mod (1)
Residual
golang/mockDependencies DetectedThe
github.com/golang/mockdependency is still present across multiple modules and should be fully removed or replaced to align with the PR objectives.
github.com/golang/mockfound in numerousgo.sumfiles throughout the repository.🔗 Analysis chain
Line range hint
1-304: Alignment with PR objectivesThe changes in this file align with the PR objectives of updating dependencies. However, the explicit removal of the
golang/mockdependency is not visible in this file. This might be because the removal is handled internally by the updatedcosmossdk.io/core/testingmodule.To confirm the removal of the
golang/mockdependency, please run:🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if golang/mock is still present in any form grep -R "github.com/golang/mock" . # Check if go.uber.org/mock is now being used grep -R "go.uber.org/mock" .Length of output: 28202
x/auth/ante/sigverify_test.go (1)
Line range hint
1-524: Consider improving test structure and readabilityWhile the tests are comprehensive, there are a few suggestions to enhance the overall quality of the test file:
- Consistency in test structure: Consider using subtests consistently across all test functions for better organization and easier debugging.
- Use of constants: Replace magic numbers (e.g., in
TestConsumeSignatureVerificationGas) with named constants to improve readability.- Error messages: Enhance error messages in assertions to provide more context when tests fail.
Example of using subtests consistently:
func TestSigVerification(t *testing.T) { // ... setup code ... testCases := []struct { name string // ... other fields ... }{ // ... test cases ... } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { // ... test logic ... }) } }Example of using named constants:
const ( defaultAccountNumber = 1000 defaultGasLimit = 200000 )Example of more descriptive error messages:
require.NoError(t, err, "Failed to create test tx: %v", err)These changes would improve the maintainability and readability of the tests.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (33)
client/v2/go.sumis excluded by!**/*.sumcollections/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumorm/go.sumis excluded by!**/*.sumruntime/v2/go.sumis excluded by!**/*.sumserver/v2/cometbft/go.sumis excluded by!**/*.sumserver/v2/go.sumis excluded by!**/*.sumsimapp/go.sumis excluded by!**/*.sumsimapp/v2/go.sumis excluded by!**/*.sumstore/go.sumis excluded by!**/*.sumstore/v2/go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sumx/accounts/defaults/base/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.sumis excluded by!**/*.sumx/accounts/defaults/multisig/go.sumis excluded by!**/*.sumx/accounts/go.sumis excluded by!**/*.sumx/authz/go.sumis excluded by!**/*.sumx/bank/go.sumis excluded by!**/*.sumx/circuit/go.sumis excluded by!**/*.sumx/consensus/go.sumis excluded by!**/*.sumx/distribution/go.sumis excluded by!**/*.sumx/epochs/go.sumis excluded by!**/*.sumx/evidence/go.sumis excluded by!**/*.sumx/feegrant/go.sumis excluded by!**/*.sumx/gov/go.sumis excluded by!**/*.sumx/group/go.sumis excluded by!**/*.sumx/mint/go.sumis excluded by!**/*.sumx/nft/go.sumis excluded by!**/*.sumx/params/go.sumis excluded by!**/*.sumx/protocolpool/go.sumis excluded by!**/*.sumx/slashing/go.sumis excluded by!**/*.sumx/staking/go.sumis excluded by!**/*.sumx/upgrade/go.sumis excluded by!**/*.sum
📒 Files selected for processing (35)
- client/v2/go.mod (1 hunks)
- collections/go.mod (1 hunks)
- docs/build/building-modules/16-testing.md (1 hunks)
- go.mod (1 hunks)
- orm/go.mod (1 hunks)
- runtime/v2/go.mod (1 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- server/v2/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- store/go.mod (1 hunks)
- store/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- x/accounts/defaults/base/go.mod (1 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/ante/sigverify_test.go (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (9)
- client/v2/go.mod
- collections/go.mod
- orm/go.mod
- store/v2/go.mod
- x/accounts/defaults/lockup/go.mod
- x/accounts/defaults/multisig/go.mod
- x/authz/go.mod
- x/consensus/go.mod
- x/evidence/go.mod
🧰 Additional context used
📓 Path-based instructions (3)
docs/build/building-modules/16-testing.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"x/auth/ante/sigverify_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
🔇 Additional comments (28)
store/go.mod (1)
7-7: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency as mentioned in the linked issue #22313.server/v2/go.mod (2)
Line range hint
48-48: Verify the necessity of the new indirect dependency.A new indirect dependency
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5has been added. While this wasn't explicitly mentioned in the PR objectives, it might be a side effect of the core/testing update.Please confirm that this new dependency is indeed necessary:
#!/bin/bash # Description: Verify the necessity of the new indirect dependency # Test: Check which direct dependency requires cosmossdk.io/errors/v2 go mod graph | rg 'cosmossdk.io/errors/v2' # Test: Verify if removing the indirect dependency causes any issues go mod tidy if ! rg 'cosmossdk.io/errors/v2' go.mod; then echo "The indirect dependency was removed by go mod tidy, suggesting it might not be necessary." else echo "The indirect dependency is retained after go mod tidy, confirming its necessity." fi
17-17: Approve the core/testing module update.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes:
x/params/go.mod (1)
8-8: Version update forcosmossdk.io/core/testinglooks good.The update to
v0.0.0-20241021095809-fc91e7635451aligns with the PR objectives to bump the core/testing module. This change is consistent with the goal of removing the golang/mock dependency.To ensure consistency across the project, let's verify if this version is used in other modules:
✅ Verification successful
Version update for
cosmossdk.io/core/testingis consistent across all modules.All
go.modfiles have been updated tov0.0.0-20241021095809-fc91e7635451, ensuring uniformity and alignment with the PR objectives.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the updated version of cosmossdk.io/core/testing is consistent across all go.mod files. # Test: Search for any occurrences of cosmossdk.io/core/testing in go.mod files rg -g 'go.mod' 'cosmossdk.io/core/testing'Length of output: 2834
x/staking/go.mod (1)
9-9: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is likely part of a broader update across the Cosmos SDK ecosystem.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes or unexpected behavior in the staking module's tests. Run the following command to check for any test failures:
x/bank/go.mod (2)
Line range hint
1-33: Overall, the changes align with PR objectives.The update to
cosmossdk.io/core/testingand the presence ofgo.uber.org/mockalign with the PR objectives of migrating away from golang/mock. The suggested verifications will ensure the complete removal of golang/mock from the dependency tree.
Line range hint
20-20: Confirm complete removal of golang/mock from dependency tree.The presence of
go.uber.org/mock v0.5.0on line 20 indicates that the migration to Uber's fork has occurred. However, we should verify thatgithub.com/golang/mockhas been completely removed from the entire dependency tree of this module.To confirm the complete removal of golang/mock, please run the following command:
#!/bin/bash # Description: Verify that golang/mock is not present in any dependency # Test: Check if golang/mock is not present in any go.mod file in the repository # Expect: The command should return empty (no matches found) find . -name go.mod -exec grep -H "github.com/golang/mock" {} +x/protocolpool/go.mod (1)
9-9: Dependency version update looks good.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is consistent with the PR objectives and aligns with updates in other modules.To ensure this change indirectly affects the golang/mock dependency as intended, let's verify:
✅ Verification successful
golang/mock dependency successfully removed.
All references to
github.com/golang/mockhave been eliminated from the codebase, andgo.uber.org/mockis now used instead.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if golang/mock is still present in the module or its dependencies # Test 1: Direct dependency check echo "Checking for direct golang/mock dependency:" grep -n "github.com/golang/mock" go.mod # Test 2: Indirect dependency check echo "Checking for indirect golang/mock dependency:" go mod graph | grep "github.com/golang/mock" # Test 3: Check if go.uber.org/mock is now used echo "Checking for go.uber.org/mock usage:" grep -n "go.uber.org/mock" go.modLength of output: 498
Script:
#!/bin/bash # Description: Search the codebase for any remaining references to github.com/golang/mock and verify go.uber.org/mock usage echo "Searching for references to github.com/golang/mock in the codebase:" rg "github.com/golang/mock" --files-with-matches echo "Verifying usage of go.uber.org/mock in the codebase:" rg "go\.uber\.org/mock" --files-with-matchesLength of output: 5651
x/epochs/go.mod (1)
9-9: LGTM. Verify golang/mock removal.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objective. This change likely contributes to removing the golang/mock dependency as mentioned in the PR summary.To ensure the golang/mock dependency has been successfully removed, please run the following command:
✅ Verification successful
golang/mock has been successfully removed
The
golang/mockdependency is no longer present ingo.modand there are no imports ofgithub.com/golang/mockin the codebase.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that golang/mock is not present in the go.mod file or any imported packages go list -m all | grep github.com/golang/mock || echo "golang/mock not found in dependencies"Length of output: 201
Script:
#!/bin/bash # Check for golang/mock in go.mod grep "github.com/golang/mock" go.mod || echo "golang/mock not found in go.mod"Length of output: 109
Script:
#!/bin/bash # Search for any golang/mock imports in .go files grep -r --include="*.go" "github.com/golang/mock" . || echo "No golang/mock imports found in codebase"Length of output: 142
x/nft/go.mod (1)
28-28: LGTM. Verify compatibility with the new core/testing version.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change appears to be part of the effort to remove the golang/mock dependency.To ensure compatibility, please verify that this new version of core/testing works as expected with the nft module. Consider running the module's tests to confirm there are no regressions.
x/circuit/go.mod (2)
9-9: Version update aligns with PR objectivesThe update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is consistent with the PR's goal of bumping the core/testing module to remove the golang/mock dependency. The specific commit hash (fc91e76) matches the one mentioned in the PR title.
Line range hint
1-238: No unexpected changes detectedI've reviewed the entire file, and the only change is the version update of
cosmossdk.io/core/testing. All other dependencies, replace directives, and the overall structure of the go.mod file remain unchanged. This focused change aligns well with the PR objectives.x/distribution/go.mod (2)
9-9: Ensure compatibility with the updatedcosmossdk.io/core/testingversion.While the version update appears to be isolated and shouldn't introduce conflicts, it's crucial to verify that this new version of
cosmossdk.io/core/testingis fully compatible with the current module and its dependencies. Please ensure that all tests pass and that there are no unexpected behaviors introduced by this change.To verify compatibility, please run the following:
#!/bin/bash # Description: Run tests for the x/distribution module to ensure compatibility # Expected: All tests should pass without errors echo "Running tests for x/distribution module:" go test ./x/distribution/...
9-9: Version update forcosmossdk.io/core/testinglooks good.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451is consistent with the PR objectives to bump the core/testing module. This change aligns with the goal of removing the golang/mock dependency as mentioned in the PR summary.To ensure consistency across the project, let's verify if this version is used in other modules:
✅ Verification successful
All
cosmossdk.io/core/testingversions are consistent across the project.
The update tocosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451is uniformly applied in all relevantgo.modfiles, aligning with the PR objectives.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the updated version of cosmossdk.io/core/testing is consistent across all go.mod files # Expected: All occurrences should use the same version (v0.0.0-20241021095809-fc91e7635451) echo "Checking cosmossdk.io/core/testing version across go.mod files:" find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} +Length of output: 3265
x/accounts/go.mod (1)
9-9: Version update forcosmossdk.io/core/testinglooks good.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objective to bump the core/testing module. This change is consistent with the goal of removing the golang/mock dependency.To ensure consistency across the project, let's verify if this version is used in other modules:
✅ Verification successful
Dependency version consistent across modules.
The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451is consistently used across all modules, ensuring version consistency and avoiding potential conflicts.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the same version of cosmossdk.io/core/testing is used in other go.mod files grep -R "cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451" --include="go.mod" .Length of output: 2898
x/mint/go.mod (1)
9-9: Version update forcosmossdk.io/core/testinglooks good.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objective to bump the core/testing module. This change is consistent with the goal of removing the golang/mock dependency.To ensure this update doesn't introduce any conflicts, please run the following command:
x/gov/go.mod (1)
9-9: LGTM. Verify the compatibility of the new core/testing version.The update to
cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.To ensure compatibility, please run the following command and verify that all tests pass:
x/accounts/defaults/base/go.mod (1)
22-22: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives to update the core/testing module. This change is part of the effort to remove the golang/mock dependency.Let's verify if this version update is consistent across the repository:
✅ Verification successful
Verified: Consistent version update for core/testing module across all go.mod files.
All
go.modfiles have been updated to usecosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451, ensuring consistency throughout the repository.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the core/testing version is consistent across all go.mod files # Test: Search for core/testing version in all go.mod files rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451' # Expected: All occurrences should show the same versionLength of output: 2818
x/feegrant/go.mod (1)
9-9: Approved: Version update aligns with PR objectivesThe update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is correct and matches the commit hash mentioned in the PR title. This change is in line with the PR's objective to update the core/testing module and potentially remove the golang/mock dependency.server/v2/cometbft/go.mod (1)
46-46: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of bumping core/testing to a specific commit. This change likely contributes to the removal of the golang/mock dependency.To ensure this update doesn't introduce any unexpected changes, please run the following verification script:
go.mod (1)
Line range hint
1-1: LGTM: golang/mock dependency removed as intended.The
github.com/golang/mockdependency has been successfully removed from thego.modfile. This change aligns with the PR objectives and the migration togo.uber.org/mock.To ensure that there are no remaining references to the removed package, please run the following verification script:
#!/bin/bash # Description: Check for any remaining usage of github.com/golang/mock in the codebase. # Test: Search for import statements or usage of golang/mock rg -i 'github.com/golang/mock' # Test: Check if there are any files still using mockgen from golang/mock fd -e go | xargs grep -n 'mockgen'If any results are found, they should be updated to use
go.uber.org/mockinstead.x/group/go.mod (1)
8-8: LGTM: Dependency version update looks good.The update of
cosmossdk.io/core/testingto the latest version (v0.0.0-20241021095809-fc91e7635451) is in line with the PR objectives. This change should help remove the golang/mock dependency as intended.To ensure compatibility, please verify that this update doesn't introduce any breaking changes in the x/group module's tests. You can run the following command to check:
x/upgrade/go.mod (1)
8-8: LGTM: Dependency update aligns with PR objectives.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of updating dependencies.To ensure this change removes the golang/mock dependency as intended, please run the following command:
✅ Verification successful
LGTM: Dependency
golang/mocksuccessfully removed.The
cosmossdk.io/core/testingmodule no longer includesgolang/mockas a dependency, ensuring the dependency update meets the PR objectives.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that golang/mock is no longer a dependency in the updated core/testing module. # Expected result: No output if golang/mock is not present. go list -m -json cosmossdk.io/core/[email protected] | jq -r '.Deps[]' | grep -i "golang/mock" || echo "golang/mock not found in dependencies"Length of output: 274
Script:
#!/bin/bash # Description: Verify that golang/mock is not present in the go.mod file of x/upgrade # Expected result: No output if golang/mock is not present. grep -i "golang/mock" x/upgrade/go.mod || echo "golang/mock not found in x/upgrade/go.mod"Length of output: 131
tests/go.mod (1)
Line range hint
36-44: Multiple dependency updatesSeveral other dependencies have been updated, including
cosmossdk.io/x/accounts,cosmossdk.io/x/gov, and others. These updates are consistent with the overall objective of the PR to update dependencies.To ensure these updates don't introduce any conflicts or breaking changes, please run:
simapp/go.mod (1)
10-10: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives and is consistent with changes in other modules.To ensure consistency across the codebase, let's verify this update in other modules:
✅ Verification successful
Verified:
cosmossdk.io/core/testingversion is consistently updated across all modules.All
go.modfiles have been checked and thecosmossdk.io/core/testingdependency is uniformly set to versionv0.0.0-20241021095809-fc91e7635451.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of core/testing version across modules # Expected result: All occurrences should show the same version rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'Length of output: 2818
simapp/v2/go.mod (1)
61-61: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives and is consistent with updates in other modules.To ensure consistency across the project, let's verify this version update in other modules:
✅ Verification successful
Verified: Consistent version update across all modules.
The version
v0.0.0-20241021095809-fc91e7635451forcosmossdk.io/core/testingis uniformly updated across all relatedgo.modfiles, ensuring consistency throughout the project.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the version of cosmossdk.io/core/testing across all go.mod files # Expected result: All occurrences should show the same version rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'Length of output: 2818
x/auth/ante/sigverify_test.go (2)
Line range hint
1-524: Summary of review for sigverify_test.goThe main change in this file, updating the import statement to use
go.uber.org/mock/gomock, has been reviewed and approved. This change aligns with the PR objective to migrate from the deprecated golang/mock to the maintained fork provided by Uber.While the tests are comprehensive and cover important aspects of signature verification, some suggestions have been provided to improve the overall structure and readability of the test suite. These suggestions are not critical but could enhance the maintainability of the tests in the long run.
Overall, the changes made in this file are minimal and do not introduce any functional changes to the tests themselves.
8-8: Import statement updated to use go.uber.org/mock/gomockThe import statement has been updated from
"github.com/golang/mock/gomock"to"go.uber.org/mock/gomock". This change aligns with the PR objective to migrate from the deprecated golang/mock to the maintained fork provided by Uber.To ensure that this change doesn't require any further updates in the file, let's verify the usage of gomock:
✅ Verification successful
Import statement successfully updated to go.uber.org/mock/gomock
The change has been verified:
- No remaining references to
github.com/golang/mock/gomockfound.- All usages of
gomockwithin the file are compatible with the new import.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if there are any remaining references to github.com/golang/mock/gomock rg "github.com/golang/mock/gomock" x/auth/ante/sigverify_test.go # Check if there are any incompatibilities with the new import rg "gomock\." x/auth/ante/sigverify_test.goLength of output: 423
| @@ -30,7 +30,7 @@ require ( | |||
| require ( | |||
| buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.35.1-20240701160653-fedbb9acfd2f.1 // indirect | |||
| buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.35.1-20240130113600-88ef6483f90f.1 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 // indirect | |||
There was a problem hiding this comment.
💡 Codebase verification
golang/mock dependency not fully removed from core/testing module.
The github.com/golang/mock dependency is still present in the following files, which needs to be removed to align with the PR objectives:
- core/testing/store.go
- core/testing/services_test.go
- core/testing/noop.go
- core/testing/memdb_test.go
- core/testing/memdb.go
- core/testing/go.mod
- core/testing/event.go
- core/testing/context.go
- core/testing/gas/service_mocks.go
🔗 Analysis chain
Version update looks good, verify core/testing changes.
The update of cosmossdk.io/core/testing to v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change reflects the latest commit as mentioned in the PR title.
To ensure this update achieves the goal of removing golang/mock, please run the following script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the removal of golang/mock from core/testing
# Test: Check if golang/mock is still present in the core/testing module
rg -i 'github.com/golang/mock' $(fd -t f -e go -e mod . | grep 'core/testing')
# Test: Check if go.uber.org/mock is now used instead
rg -i 'go.uber.org/mock' $(fd -t f -e go -e mod . | grep 'core/testing')
Length of output: 706
| @@ -30,7 +30,7 @@ require ( | |||
| require ( | |||
| buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.35.1-20240701160653-fedbb9acfd2f.1 // indirect | |||
| buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.35.1-20240130113600-88ef6483f90f.1 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
golang/mock dependency still present in tools/confix/go.mod.
- Remove or replace the dependency in
tools/confix/go.mod.
🔗 Analysis chain
Version update looks good, but verify golang/mock removal.
The update to cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. However, we should verify that this version indeed removes the golang/mock dependency as intended.
To confirm the removal of golang/mock, please run the following command:
[/run_scripts]
[/run_scripts]
[/run_scripts]
[/run_scripts]
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that golang/mock is not present in the dependencies of core/testing
# Test: Check if golang/mock is not present in the go.mod of core/testing
# Expect: The command should return empty (no matches found)
curl -s https://raw.githubusercontent.com/cosmos/cosmos-sdk/fc91e7635451/core/testing/go.mod | grep "github.com/golang/mock"
Length of output: 317
Script:
#!/bin/bash
# Description: Locate core/testing/go.mod and verify the absence of github.com/golang/mock
# Find the path to core/testing/go.mod
go_mod_path=$(fd --search-path core/testing --exact-depth 2 --name go.mod)
# Check if the go.mod file exists
if [ -f "$go_mod_path" ]; then
# Search for github.com/golang/mock in the found go.mod
grep "github.com/golang/mock" "$go_mod_path"
else
echo "core/testing/go.mod not found."
fi
Length of output: 447
Script:
#!/bin/bash
# Description: Locate core/testing/go.mod and verify the absence of github.com/golang/mock
# Find the path to core/testing/go.mod
go_mod_path=$(fd 'go.mod' core/testing --exact-depth 2)
# Check if the go.mod file exists
if [ -f "$go_mod_path" ]; then
# Search for github.com/golang/mock in the found go.mod
grep "github.com/golang/mock" "$go_mod_path"
else
echo "core/testing/go.mod not found."
fi
Length of output: 143
Script:
#!/bin/bash
# Description: Search all go.mod files for github.com/golang/mock to verify its removal
# Find all go.mod files in the repository
fd 'go.mod' -type f | while read -r go_mod; do
echo "Checking $go_mod for github.com/golang/mock..."
grep -H "github.com/golang/mock" "$go_mod"
done
Length of output: 207
Script:
#!/bin/bash
# Description: Search all go.mod files for github.com/golang/mock to verify its removal
# Find all go.mod files in the repository
fd 'go.mod' --type file | while read -r go_mod; do
echo "Checking $go_mod for github.com/golang/mock..."
grep -H "github.com/golang/mock" "$go_mod"
done
Length of output: 10379
| @@ -6,7 +6,7 @@ require ( | |||
| cosmossdk.io/api v0.7.6 | |||
| cosmossdk.io/collections v0.4.0 | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Golang/mock dependency still present in the codebase.
- Found in
tools/confix/go.modas an indirect dependency. - Multiple
go.sumfiles still referencegithub.com/golang/mock.
🔗 Analysis chain
LGTM. Verify implications of core/testing update.
The update to cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change likely contributes to removing the golang/mock dependency as intended.
To ensure this update doesn't introduce any unforeseen issues:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the golang/mock dependency has been removed and there are no conflicts.
# Test 1: Check if golang/mock is still present in any go.mod file
echo "Checking for golang/mock in go.mod files:"
find . -name go.mod -exec grep -H "github.com/golang/mock" {} +
# Test 2: Verify if there are any build issues after the update
echo "Running go mod tidy to check for any dependency issues:"
go mod tidy
go mod verify
# Test 3: Check if there are any references to golang/mock in the code
echo "Checking for golang/mock references in the code:"
grep -R "github.com/golang/mock" .
Length of output: 14500
| @@ -6,7 +6,7 @@ require ( | |||
| cosmossdk.io/api v0.7.6 | |||
| cosmossdk.io/collections v0.4.0 | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Issues Found: github.com/golang/mock dependency still present.
The github.com/golang/mock dependency remains in multiple go.sum files and is referenced in test utilities, indicating that it was not fully removed as intended.
🔗 Analysis chain
LGTM: Core testing module updated as intended.
The cosmossdk.io/core/testing module has been successfully updated to the latest pre-release version. This change aligns with the PR objectives.
To ensure compatibility across the Cosmos SDK ecosystem, please run the following verification script:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that the core/testing update doesn't introduce breaking changes.
# Test: Check if any tests fail after the update
go test ./...
# Test: Verify if there are any compilation errors in the codebase
go build ./...
Length of output: 18409
| @@ -32,7 +32,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Golang/mock dependency still present in the codebase
The github.com/golang/mock dependency remains in multiple modules, indicating it was not fully removed as intended. Please ensure all instances are addressed to align with the PR objectives.
🔗 Analysis chain
Version update for core/testing module
The cosmossdk.io/core/testing module has been updated to version v0.0.0-20241021095809-fc91e7635451. This change aligns with the PR objective of updating dependencies.
To ensure this update doesn't introduce any breaking changes, please run the following command:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if there are any breaking changes in the core/testing module
go mod tidy
go test ./...
Length of output: 28202
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Outside diff range and nitpick comments (4)
docs/build/building-modules/16-testing.md (2)
25-25: LGTM! Consider adding version information.The update to the mockgen URL is correct and aligns with the PR objectives. To future-proof the documentation, consider adding a note about the version of
go.uber.org/mockbeing used.You could add a version reference like this:
You can read more about mockgen [here](https://go.uber.org/mock) (version X.X.X as of this writing).
Line range hint
91-93: LGTM! Consider expanding the note with an example.The addition of the note about simulations using message factories is valuable. To make it more helpful for developers, consider expanding this section with a brief example or a link to more detailed documentation about message factories.
You could enhance this section like this:
:::note Simulations have been refactored to use message factories. For example, see the `x/bank` module's message factory implementation: ```go // Example from x/bank/simulation/msg_factory.go func NewMsgFactory() simtypes.MsgFactory { return simtypes.NewMsgFactory( simtypes.NewMsgFactoryEntry("send", NewMsgSend), // ... other message types ... ) }For more details on implementing message factories, see [link to detailed docs].
:::</blockquote></details> <details> <summary>x/params/go.mod (1)</summary><blockquote> Line range hint `3-3`: **Fix invalid Go version.** The specified Go version `1.23.1` is not a valid Go release. This could lead to compatibility issues and build problems. Please update the Go version to a valid and current release. For example: ```diff -go 1.23.1 +go 1.21Make sure to use a version that is compatible with the project's requirements and other dependencies.
simapp/v2/go.mod (1)
Line range hint
1-24: Note: Careful management of local replacementsWhile not directly related to the changes in this PR, it's worth noting the extensive use of local replacements for various modules in this
go.modfile. This setup is typical for development and testing purposes in the Cosmos SDK ecosystem. However, it's crucial to manage these replacements carefully to ensure consistency and avoid potential conflicts in the future.Consider periodically reviewing and updating these replacements to align with the latest stable versions of the respective modules. This practice will help maintain the project's stability and compatibility with the broader Cosmos SDK ecosystem.
Also applies to: 62-341
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
⛔ Files ignored due to path filters (33)
client/v2/go.sumis excluded by!**/*.sumcollections/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumorm/go.sumis excluded by!**/*.sumruntime/v2/go.sumis excluded by!**/*.sumserver/v2/cometbft/go.sumis excluded by!**/*.sumserver/v2/go.sumis excluded by!**/*.sumsimapp/go.sumis excluded by!**/*.sumsimapp/v2/go.sumis excluded by!**/*.sumstore/go.sumis excluded by!**/*.sumstore/v2/go.sumis excluded by!**/*.sumtests/go.sumis excluded by!**/*.sumx/accounts/defaults/base/go.sumis excluded by!**/*.sumx/accounts/defaults/lockup/go.sumis excluded by!**/*.sumx/accounts/defaults/multisig/go.sumis excluded by!**/*.sumx/accounts/go.sumis excluded by!**/*.sumx/authz/go.sumis excluded by!**/*.sumx/bank/go.sumis excluded by!**/*.sumx/circuit/go.sumis excluded by!**/*.sumx/consensus/go.sumis excluded by!**/*.sumx/distribution/go.sumis excluded by!**/*.sumx/epochs/go.sumis excluded by!**/*.sumx/evidence/go.sumis excluded by!**/*.sumx/feegrant/go.sumis excluded by!**/*.sumx/gov/go.sumis excluded by!**/*.sumx/group/go.sumis excluded by!**/*.sumx/mint/go.sumis excluded by!**/*.sumx/nft/go.sumis excluded by!**/*.sumx/params/go.sumis excluded by!**/*.sumx/protocolpool/go.sumis excluded by!**/*.sumx/slashing/go.sumis excluded by!**/*.sumx/staking/go.sumis excluded by!**/*.sumx/upgrade/go.sumis excluded by!**/*.sum
📒 Files selected for processing (35)
- client/v2/go.mod (1 hunks)
- collections/go.mod (1 hunks)
- docs/build/building-modules/16-testing.md (1 hunks)
- go.mod (1 hunks)
- orm/go.mod (1 hunks)
- runtime/v2/go.mod (1 hunks)
- server/v2/cometbft/go.mod (1 hunks)
- server/v2/go.mod (1 hunks)
- simapp/go.mod (1 hunks)
- simapp/v2/go.mod (1 hunks)
- store/go.mod (1 hunks)
- store/v2/go.mod (1 hunks)
- tests/go.mod (1 hunks)
- x/accounts/defaults/base/go.mod (1 hunks)
- x/accounts/defaults/lockup/go.mod (1 hunks)
- x/accounts/defaults/multisig/go.mod (1 hunks)
- x/accounts/go.mod (1 hunks)
- x/auth/ante/sigverify_test.go (1 hunks)
- x/authz/go.mod (1 hunks)
- x/bank/go.mod (1 hunks)
- x/circuit/go.mod (1 hunks)
- x/consensus/go.mod (1 hunks)
- x/distribution/go.mod (1 hunks)
- x/epochs/go.mod (1 hunks)
- x/evidence/go.mod (1 hunks)
- x/feegrant/go.mod (1 hunks)
- x/gov/go.mod (1 hunks)
- x/group/go.mod (1 hunks)
- x/mint/go.mod (1 hunks)
- x/nft/go.mod (1 hunks)
- x/params/go.mod (1 hunks)
- x/protocolpool/go.mod (1 hunks)
- x/slashing/go.mod (1 hunks)
- x/staking/go.mod (1 hunks)
- x/upgrade/go.mod (1 hunks)
✅ Files skipped from review due to trivial changes (10)
- collections/go.mod
- orm/go.mod
- simapp/go.mod
- x/accounts/defaults/lockup/go.mod
- x/accounts/defaults/multisig/go.mod
- x/authz/go.mod
- x/circuit/go.mod
- x/consensus/go.mod
- x/nft/go.mod
- x/upgrade/go.mod
🧰 Additional context used
📓 Path-based instructions (3)
docs/build/building-modules/16-testing.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"tests/go.mod (1)
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"x/auth/ante/sigverify_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
🔇 Additional comments (26)
store/v2/go.mod (2)
7-7: LGTM: Core testing package update to remove golang/mock.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objective to update to a specific commit (fc91e76) and remove the golang/mock dependency.To ensure the golang/mock dependency has been successfully removed, run the following script:
#!/bin/bash # Description: Verify the removal of golang/mock dependency and its replacement with go.uber.org/mock. # Test 1: Check if golang/mock is still present in any go.mod file echo "Checking for golang/mock in go.mod files:" rg -i 'github\.com/golang/mock' --type go-mod # Test 2: Check if go.uber.org/mock is now used instead echo "Checking for go.uber.org/mock in go.mod files:" rg -i 'go\.uber\.org/mock' --type go-mod # Test 3: Check for any remaining imports of golang/mock in Go files echo "Checking for golang/mock imports in Go files:" rg -i 'github\.com/golang/mock' --type go # Test 4: Check for new imports of go.uber.org/mock in Go files echo "Checking for go.uber.org/mock imports in Go files:" rg -i 'go\.uber\.org/mock' --type go
6-6: LGTM: Core package version update.The update of
cosmossdk.io/corefromv1.0.0-alpha.3tov1.0.0-alpha.4aligns with the PR objectives. This change is consistent across multiple modules in the Cosmos SDK.Please ensure that this version update is compatible with the rest of the codebase. Run the following script to check for any potential conflicts:
✅ Verification successful
Verification Successful: All
cosmossdk.io/coreversions updated tov1.0.0-alpha.4.All
go.modfiles across the codebase have been updated tocosmossdk.io/core v1.0.0-alpha.4. No version conflicts or discrepancies detected.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential conflicts with the updated core package version. # Test: Search for imports of the core package and any version-specific code. rg -i 'cosmossdk\.io/core.*v1\.0\.0-alpha\.'Length of output: 7143
Script:
#!/bin/bash # Description: Verify the updated `cosmossdk.io/core` version in store/v2/go.mod. # Search for the specific version update in the go.mod file. rg -i 'cosmossdk\.io/core\s*v1\.0\.0-alpha\.4' store/v2/go.modLength of output: 98
Script:
#!/bin/bash # Description: Verify that all go.mod files have `cosmossdk.io/core` updated to `v1.0.0-alpha.4`. # Search for `cosmossdk.io/core` in all go.mod files and display their versions. rg -i 'cosmossdk\.io/core\s*v1\.0\.0-alpha\.' -g '**/go.mod' --no-filename --color neverLength of output: 1355
server/v2/go.mod (1)
17-17: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is consistent with the PR's goal of updating to commit fc91e76 to remove the golang/mock dependency.Let's verify if this change is consistent across other modules:
docs/build/building-modules/16-testing.md (1)
Line range hint
110-112: LGTM! Clear and helpful guidance.The addition of the note about using the
simappbinary while encouraging developers to use their own binaries is a valuable clarification. It provides clear guidance while maintaining flexibility for different project setups.x/params/go.mod (1)
8-8: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.To ensure compatibility, please verify that this version update doesn't introduce any breaking changes or issues in the x/params module. Consider running the module's tests with the updated dependency to confirm everything works as expected.
x/staking/go.mod (1)
9-9: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.To ensure compatibility, please verify that all tests pass with this new version and that there are no breaking changes introduced. You may want to run the following command in the project root:
x/bank/go.mod (3)
Line range hint
1-227: LGTM: Changes are focused and align with PR objectives.The modifications in this file are limited to updating the
cosmossdk.io/core/testingdependency and adding two new indirect protobuf dependencies. All other aspects of thego.modfile, including other dependencies, replace directives, and the Go version, remain unchanged. This focused approach aligns well with the PR's primary objective of updating the core/testing module to remove the golang/mock dependency.
Line range hint
28-29: New indirect dependencies added: Clarification needed.Two new indirect dependencies related to protocol buffers have been added:
buf.build/gen/go/cometbft/cometbft/protocolbuffers/gobuf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goWhile these additions are likely beneficial, could you please clarify:
- The specific reason for adding these dependencies?
- Any potential impact on the module's functionality or performance?
To understand the usage of these new dependencies, run:
#!/bin/bash # Description: Check for usage of new protobuf dependencies # Test: Search for import statements using the new dependencies rg 'import.*buf\.build/gen/go/(cometbft/cometbft|cosmos/gogo-proto)/protocolbuffers/go'
33-33: LGTM: Core testing dependency updated as intended.The
cosmossdk.io/core/testingdependency has been successfully updated to the specified commitfc91e7635451. This change aligns with the PR objectives to remove the golang/mock dependency.To ensure consistency across the project, run the following script:
✅ Verification successful
Action Required:
Please execute the following script to verify that all modules use the specified version of
cosmossdk.io/core/testing:
Action Required:
Please execute the following script to verify that unwanted import statements have been removed from the codebase:
Action Required:
Please execute the following script to list all
.gofiles in the repository and verify their presence:
Action Required:
Please execute the following script to verify that unwanted import statements from
buf.build/gen/go/cometbft/cometbftorcosmos/gogo-proto/protocolbuffers/gohave been removed from all.gofiles:
Verified: Unwanted import statements have been removed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all modules use the same version of cosmossdk.io/core/testing # Test: Check for consistent version usage across all go.mod files rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'Length of output: 183
Script:
#!/bin/bash # Description: Verify that all modules use the same version of cosmossdk.io/core/testing # Test: Check for consistent version usage across all go.mod files rg -g 'go.mod' "cosmossdk.io/core/testing v0\.0\.0-20241021095809-fc91e7635451"Length of output: 2820
Script:
#!/bin/bash # Description: Verify that unwanted imports from buf.build/gen/go/cometbft/cometbft or cosmos/gogo-proto/protocolbuffers/go are removed. # Test: Search for specific unwanted import patterns in .go files rg "import.*buf\.build/gen/go/(cometbft/cometbft|cosmos/gogo-proto)/protocolbuffers/go" -- "*.go"Length of output: 144
Script:
#!/bin/bash # Description: List all .go files in the repository # Test: Confirm that .go files exist and are located properly fd --extension goLength of output: 90341
Script:
#!/bin/bash # Description: Verify that unwanted imports from buf.build/gen/go/cometbft/cometbft or cosmos/gogo-proto/protocolbuffers/go are removed. # Test: Search for specific unwanted import patterns in .go files rg -g "*.go" "import.*buf\.build/gen/go/(cometbft/cometbft|cosmos/gogo-proto)/protocolbuffers/go"Length of output: 99
x/evidence/go.mod (1)
9-9: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.To ensure compatibility, please verify that all tests pass with this new version and that there are no breaking changes introduced.
x/epochs/go.mod (1)
9-9: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.To ensure compatibility, please verify that all tests pass with this new version and that there are no breaking changes introduced. Consider running:
x/distribution/go.mod (1)
9-9: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.To ensure compatibility, please verify that all tests pass with this new version and that there are no breaking changes introduced. Consider running the following command to check for any potential issues:
✅ Verification successful
All tests passed successfully with the updated core/testing module.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with the new core/testing version # Test: Run go test and check for any failures go test ./... 2>&1 | tee test_output.log if grep -q "FAIL" test_output.log; then echo "Some tests failed. Please review the output." else echo "All tests passed successfully." fiLength of output: 259
Script:
#!/bin/bash # Description: Verify compatibility with the new core/testing version without using 'tee' # Run go tests and check for any failures if go test ./... 2>&1 | grep -q "FAIL"; then echo "Some tests failed. Please review the output." exit 1 else echo "All tests passed successfully." fiLength of output: 101
x/accounts/go.mod (1)
9-9: LGTM: Version update is consistent with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR's goal of updating the core/testing module. This change is consistent with updates in other modules mentioned in the PR summary.To ensure consistency across the project, let's verify this update in other modules:
x/mint/go.mod (1)
9-9: Verify consistency and impact of the core/testing update.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. However, please ensure:
- This version update is consistent across all relevant modules in the PR.
- The update successfully removes the golang/mock dependency as intended.
- There are no breaking changes introduced by this update that might affect the mint module or its tests.
To confirm the removal of golang/mock and check for any remaining references, run:
x/gov/go.mod (1)
9-9: LGTM: Dependency update aligns with PR objectives.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451is consistent with the PR objectives and the changes observed in other modules. This change likely supports the migration from golang/mock to go.uber.org/mock/mockgen.To ensure consistency across the project, let's verify that this version is used in other modules:
✅ Verification successful
Verified: All modules consistently use the updated
cosmossdk.io/core/testingversion.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the same version of cosmossdk.io/core/testing is used across all go.mod files # Find all go.mod files and grep for the core/testing dependency find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} \;Length of output: 2932
client/v2/go.mod (1)
26-26: LGTM: Version update for core/testing module.The update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives and the broader effort to migrate to a more maintained mocking tool.To ensure consistency across the repository, let's verify if this update has been applied to other modules:
✅ Verification successful
Verified:
cosmossdk.io/core/testingversion is consistent across all modules.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the core/testing version is consistent across all go.mod files # Find all go.mod files and grep for the core/testing dependency find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} \;Length of output: 2932
x/accounts/defaults/base/go.mod (1)
22-22: LGTM: Version update aligns with PR objectives.The update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is in line with the PR's goal of updating the core/testing module. This change is part of the broader effort to migrate to a more maintained mocking tool.To ensure consistency across the project, let's verify this update in other modules:
✅ Verification successful
Verified:
cosmossdk.io/core/testingversion is consistently updated across all modules.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of core/testing version across modules # Expected: All occurrences should show the new version rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'Length of output: 2818
x/feegrant/go.mod (1)
9-9: Version update aligns with PR objectivesThe update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451is correct and matches the commit hash (fc91e76) mentioned in the PR objectives. This change is part of the effort to remove the golang/mock dependency.server/v2/cometbft/go.mod (3)
Line range hint
3-3: Verify the Go versionThe specified Go version (1.23.1) appears to be non-standard. Go versions typically follow the format x.y (e.g., 1.23). Please verify if this is the correct version you intend to use, or if it should be updated to a standard Go version (e.g., 1.23 or 1.24).
46-46: LGTM: Core/testing version updateThe update of
cosmossdk.io/core/testingtov0.0.0-20241021095809-fc91e7635451aligns with the PR objective to bump the core/testing module to the specified commit. This change is consistent across multiple modules as mentioned in the PR summary.
44-45: LGTM: New indirect dependencies addedThe addition of two new indirect dependencies is consistent with updates in other modules:
buf.build/gen/go/cometbft/cometbft/protocolbuffers/gobuf.build/gen/go/cosmos/gogo-proto/protocolbuffers/goThese appear to be generated protobuf dependencies. While the addition looks correct, it's advisable to verify if these dependencies are necessary for this specific module.
go.mod (1)
Line range hint
1-240: LGTM: golang/mock dependency successfully removed.The
github.com/golang/mockdependency has been successfully removed from thego.modfile, andgo.uber.org/mockis present. This change aligns with the PR objectives and the migration plan outlined in issue #22313.To ensure all references to the old mocking library have been updated, please run the following command:
x/group/go.mod (1)
8-8: LGTM: Version update for core/testing moduleThe update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451aligns with the PR objectives. This change is part of the effort to update the testing infrastructure and remove the golang/mock dependency.To ensure consistency across the repository, let's verify if this update has been applied to other modules:
✅ Verification successful
Verified: Consistent version of
cosmossdk.io/core/testingacross all modulesAll relevant
go.modfiles have been updated tov0.0.0-20241021095809-fc91e7635451forcosmossdk.io/core/testing, ensuring consistency throughout the repository.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the core/testing version is consistent across all go.mod files # Expected result: All go.mod files should have the same version of core/testing # Find all go.mod files and grep for the core/testing version find . -name go.mod -exec grep -H "cosmossdk.io/core/testing" {} \;Length of output: 2932
simapp/v2/go.mod (1)
61-61: LGTM: Version update for core/testing moduleThe update of
cosmossdk.io/core/testingto versionv0.0.0-20241021095809-fc91e7635451is in line with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.To ensure consistency across the project, let's verify that this version update has been applied uniformly:
✅ Verification successful
LGTM: Version update for core/testing module verified across all go.mod files
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent version update of cosmossdk.io/core/testing across all go.mod files # Test: Search for the new version in all go.mod files rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451' # Test: Ensure no old versions remain rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29'Length of output: 2896
x/auth/ante/sigverify_test.go (2)
Line range hint
1-1024: LGTM: Test cases remain comprehensive and well-structured.The test cases continue to provide thorough coverage for signature verification scenarios, including various key types and edge cases. The structure and naming conventions adhere to the Golang style guide.
8-8: LGTM: Import statement updated correctly.The change from
"github.com/golang/mock/gomock"to"go.uber.org/mock/gomock"aligns with the PR objective of migrating to a maintained mocking tool.To ensure compatibility, please run the following script to check for any breaking changes in the
gomockAPI:✅ Verification successful
LGTM: gomock usage is compatible with new import.
The change from
"github.com/golang/mock/gomock"to"go.uber.org/mock/gomock"appears to be safe. The existing uses of gomock in this file (creating a controller and usinggomock.Any()) are standard and should be compatible with the new import.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for potential breaking changes in gomock API usage # Test: Search for gomock method calls that might have changed rg '\bmock\b|\bgomock\b' --type goLength of output: 312258
Script:
#!/bin/bash # Check for uses of gomock in the file grep -n "gomock\." x/auth/ante/sigverify_test.goLength of output: 375
| @@ -4,7 +4,7 @@ go 1.23 | |||
|
|
|||
| require ( | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Issue: golang/mock dependency still present in tools/confix/go.mod.
The github.com/golang/mock dependency remains in tools/confix/go.mod as an indirect dependency. Please remove it to complete the removal of golang/mock from the project.
🔗 Analysis chain
LGTM: Version update for core/testing module.
The update of cosmossdk.io/core/testing to v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change appears to be part of the effort to remove the golang/mock dependency.
To ensure the update's consistency and effectiveness, please run the following verification steps:
Please review the output of these tests to confirm:
- The core/testing version is consistent across all modules.
- The golang/mock dependency has been removed.
- The go.uber.org/mock dependency is now used where necessary.
If any inconsistencies or unexpected results are found, please address them before merging.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the consistency of core/testing version across modules and check for golang/mock removal.
# Test 1: Check if the core/testing version is consistent across all go.mod files
echo "Checking core/testing version consistency:"
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'
# Test 2: Verify that golang/mock is no longer present in go.mod files
echo "Verifying golang/mock removal:"
rg -g 'go.mod' 'github.com/golang/mock'
# Test 3: Check if go.uber.org/mock is now used instead
echo "Checking for go.uber.org/mock usage:"
rg -g 'go.mod' 'go.uber.org/mock'
Length of output: 4268
| @@ -30,7 +30,7 @@ require ( | |||
| require ( | |||
| buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.35.1-20240701160653-fedbb9acfd2f.1 // indirect | |||
| buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.35.1-20240130113600-88ef6483f90f.1 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 // indirect | |||
There was a problem hiding this comment.
💡 Codebase verification
Issue: github.com/golang/mock dependency still present.
tools/confix/go.modstill includesgithub.com/golang/mock v1.6.0 // indirect
🔗 Analysis chain
LGTM: Version update aligns with PR objectives.
The update of cosmossdk.io/core/testing to v0.0.0-20241021095809-fc91e7635451 is consistent with the PR's goal of bumping core/testing to fc91e76. This change supports the effort to remove the golang/mock dependency.
To ensure consistency across the project, let's verify this update in other modules:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the consistency of core/testing version across modules
# Test: Search for the new version in all go.mod files
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'
# Test: Ensure golang/mock is not present in go.mod files
rg -g 'go.mod' 'github.com/golang/mock'
Length of output: 2919
| @@ -6,7 +6,7 @@ require ( | |||
| cosmossdk.io/api v0.7.6 | |||
| cosmossdk.io/collections v0.4.0 | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Golang/mock dependency still present.
tools/confix/go.modstill includesgithub.com/golang/mock v1.6.0 // indirect
🔗 Analysis chain
LGTM: Version update for core/testing module.
The update of cosmossdk.io/core/testing to version v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency.
To ensure consistency across the project, let's verify if this change has been applied to other modules:
Additionally, let's verify if the golang/mock dependency has been removed:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the core/testing version update is consistent across all go.mod files
# Test: Search for the new version in all go.mod files
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451'
# Test: Check if there are any remaining old versions
rg -g 'go.mod' 'cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29'
Length of output: 2896
Script:
#!/bin/bash
# Description: Check if golang/mock dependency has been removed from all go.mod files
# Test: Search for any remaining golang/mock dependencies
rg -g 'go.mod' 'github.com/golang/mock'
Length of output: 100
| @@ -6,7 +6,7 @@ require ( | |||
| cosmossdk.io/api v0.7.6 | |||
| cosmossdk.io/collections v0.4.0 | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Dependency golang/mock Still Present
golang/mockis still listed ingo.sum, indicating it hasn't been fully removed.- Please manually verify and ensure all references to
golang/mockare eliminated from the codebase. - Consider running
go mod tidyto clean up unused dependencies.
🔗 Analysis chain
LGTM: Version update for core/testing module.
The update of cosmossdk.io/core/testing to version v0.0.0-20241021095809-fc91e7635451 aligns with the PR objectives. This change is part of the effort to remove the golang/mock dependency and migrate to a more maintained mocking tool.
To ensure compatibility, please verify that all tests pass with this new version and that there are no breaking changes introduced. You can run the following command to check for any potential issues:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify compatibility with the new core/testing version
# Test: Run go test for the x/slashing module
go test ./x/slashing/...
# Check: Look for any references to golang/mock that might have been missed
rg 'github.com/golang/mock' ./x/slashing
Length of output: 445
Script:
#!/bin/bash
# Description: Search for any import statements referencing github.com/golang/mock in x/slashing module
rg 'import\s+["\']github.com/golang/mock' ./x/slashing
Length of output: 93
Script:
#!/bin/bash
# Description: Search for any import statements referencing github.com/golang/mock in x/slashing module
rg "import\s+[\"']github\.com/golang/mock[\"']" ./x/slashing
Length of output: 66
| @@ -6,7 +6,7 @@ require ( | |||
| cosmossdk.io/api v0.7.6 | |||
| cosmossdk.io/collections v0.4.0 | |||
| cosmossdk.io/core v1.0.0-alpha.4 | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Action Required: Unnecessary Dependency Detected
The github.com/golang/mock dependency is still present in multiple go.sum files, which contradicts the PR objective to remove it. Please ensure that this dependency is fully removed across the codebase.
🔗 Analysis chain
LGTM: Core testing dependency updated as intended.
The cosmossdk.io/core/testing dependency has been successfully updated to the newer version v0.0.0-20241021095809-fc91e7635451. This change aligns with the PR objectives.
To ensure compatibility, please run the following command to check for any breaking changes or deprecations:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the impact of the core/testing update
# Expected result: No errors or warnings related to the update
go mod tidy
go test ./...
Length of output: 13847
| @@ -32,7 +32,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | |||
| cosmossdk.io/core/testing v0.0.0-20241021095809-fc91e7635451 | |||
There was a problem hiding this comment.
💡 Codebase verification
Issue: Go is not installed in the testing environment.
The testing environment lacks the Go programming language, preventing tests from running successfully. Please ensure that Go is installed and properly configured to verify the updated cosmossdk.io/core/testing dependency.
🔗 Analysis chain
LGTM: Core testing dependency updated as intended.
The cosmossdk.io/core/testing dependency has been successfully updated to the specified commit (fc91e7635451), aligning with the PR objectives.
To ensure compatibility, please run the following script to check if all tests pass with the new version:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that all tests pass with the updated core/testing dependency.
# Run all tests in the repository
go test ./...
# Check the exit status
if [ $? -eq 0 ]; then
echo "All tests passed successfully with the updated core/testing dependency."
else
echo "Some tests failed. Please review the test output and address any issues."
fi
Length of output: 260
Script:
#!/bin/bash
# Description: Check if Go is installed and display its version.
if command -v go >/dev/null 2>&1; then
echo "Go is installed: $(go version)"
else
echo "Go is not installed."
fi
Length of output: 66
|
Seems it's a very large change to update core/testing module @facundomedica do you have any suggestion? |
Description
Closes: #22313
Since #22315 is merged, we can bump its version to remove golang/mock
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
cosmossdk.io/core/testingdependency across various modules, which may include bug fixes and enhancements.Documentation
Bug Fixes
Chores