-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): use cosmossdk.io/core
v1.0.0-alpha.5
#22369
Changes from 2 commits
0b13ac0
cfb39bd
288490f
faae2e1
2d8fa5a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
cosmossdk.io/core v1.0.0-alpha.4 h1:9iuroT9ejDYETCsGkzkvs/wAY/5UFl7nCIINFRxyMJY= | ||
cosmossdk.io/core v1.0.0-alpha.4/go.mod h1:3u9cWq1FAVtiiCrDPpo4LhR+9V6k/ycSG4/Y/tREWCY= | ||
cosmossdk.io/core v1.0.0-alpha.5 h1:McjYXAQ6XcT20v2uHyH7PhoWH8V+mebzfVFqT3GinsI= | ||
cosmossdk.io/core v1.0.0-alpha.5/go.mod h1:3u9cWq1FAVtiiCrDPpo4LhR+9V6k/ycSG4/Y/tREWCY= | ||
cosmossdk.io/schema v0.3.0 h1:01lcaM4trhzZ1HQTfTV8z6Ma1GziOZ/YmdzBN3F720c= | ||
cosmossdk.io/schema v0.3.0/go.mod h1:RDAhxIeNB4bYqAlF4NBJwRrgtnciMcyyg0DOKnhNZQQ= |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ replace ( | |
require ( | ||
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/collections v0.4.0 | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Version inconsistencies found in multiple modules The verification reveals inconsistencies in the
These inconsistencies should be addressed to maintain version alignment across the codebase and prevent potential compatibility issues. 🔗 Analysis chainLGTM - Verify version consistency across modules The update of
Let's verify version consistency across all modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any inconsistent versions of cosmossdk.io/core across all go.mod files
# Expected: All modules should use v1.0.0-alpha.5
echo "Checking cosmossdk.io/core versions across all go.mod files..."
fd --type f --glob "go.mod" --exec grep -l "cosmossdk.io/core" {} \; | \
while read -r file; do
echo "=== $file ==="
grep "cosmossdk.io/core" "$file"
done
Length of output: 8992 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Core package version is inconsistent across modules The verification reveals version inconsistencies of
These inconsistencies should be addressed to ensure version compatibility across the codebase. 🔗 Analysis chainVerify consistency of core package version across modules. The version update appears consistent with the AI summary mentioning similar updates across multiple modules. Let's verify the consistency: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for version consistency across all go.mod files
# Find all go.mod files and check core package version
fd -t f "go.mod" --exec grep -H "cosmossdk.io/core"
Length of output: 23161 Script: #!/bin/bash
# Check core package version in go.mod files
fd -t f "go.mod" --exec grep -H "cosmossdk.io/core"
Length of output: 5153 |
||
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/schema v0.3.1-0.20241010135032-192601639cac | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ go 1.23.1 | |
require ( | ||
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/client/v2 v2.0.0-00010101000000-000000000000 | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Inconsistent core module versions detected across the repository The verification revealed inconsistencies in the
These inconsistencies should be addressed to ensure version compatibility across the codebase. 🔗 Analysis chainVerify the impact of core version update. The update from Let's verify the version consistency across all modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if all modules are using the same version of cosmossdk.io/core
# Expected: All modules should use v1.0.0-alpha.5
# Find all go.mod files and check the version of cosmossdk.io/core
fd --type f "go.mod" --exec grep -l "cosmossdk.io/core" {} \; | while read -r file; do
echo "=== $file ==="
grep "cosmossdk.io/core" "$file"
done
Length of output: 8850 |
||
cosmossdk.io/depinject v1.0.0 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/math v1.3.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ module cosmossdk.io/store | |
go 1.23 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Go version inconsistency detected across modules The codebase shows significant version inconsistency across Go modules:
This mix of versions, especially the use of Go 1.23 which is not yet released, could lead to compatibility issues. Consider:
🔗 Analysis chainVerify Go version compatibility. The module requires Go 1.23, which appears to be a future version (current latest stable is 1.22). This might cause compatibility issues. Let's check the Go version requirements across all modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check Go version requirements across all modules
# Expected: Consistent Go version requirements
echo "Checking Go version requirements across all modules..."
fd --type f --glob 'go.mod' --exec rg --no-line-number '^go 1\.'
Length of output: 647 |
||
|
||
require ( | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | ||
cosmossdk.io/errors v1.0.1 | ||
cosmossdk.io/log v1.4.1 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ go 1.23.1 | |
require ( | ||
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/collections v0.4.0 | ||
cosmossdk.io/core v1.0.0-alpha.4 | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Inconsistent core module versions detected across the repository Several modules are not aligned with the v1.0.0-alpha.5 update:
These inconsistencies need to be addressed to maintain version compatibility across the codebase. 🔗 Analysis chainLGTM! Verify consistency across modules. The update of Let's verify that this version is consistently updated across all modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any inconsistent cosmossdk.io/core versions across go.mod files
# Expected: All modules should use v1.0.0-alpha.5
# Search for core version declarations in all go.mod files
rg "cosmossdk.io/core v" -g "go.mod"
Length of output: 2159 |
||
cosmossdk.io/depinject v1.0.0 | ||
cosmossdk.io/x/accounts v0.0.0-20240913065641-0064ccbce64e | ||
cosmossdk.io/x/tx v1.0.0-alpha.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update core dependency version in orm and store/v2 modules
The verification revealed inconsistencies in core package versions across modules. Most modules are correctly using
v1.0.0-alpha.5
, but two modules are still on older versions:orm/go.mod
is usingv1.0.0-alpha.3
store/v2/go.mod
is usingv1.0.0-alpha.3
Additionally, some tool modules (
tools/confix
,tools/cosmovisor
,tools/hubl
,tests/systemtests
) are using v0.11.x versions, but these appear to be intentional as they are developer tooling.🔗 Analysis chain
Verify compatibility with dependent modules.
The update to
cosmossdk.io/core v1.0.0-alpha.5
looks good, but since this is an alpha version, we should ensure:Let's verify the consistency of core version across all modules:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 5281