fix(simapp/v2): full AutoCLI support

client/v2/autocli/app.go

@@ -9,9 +9,13 @@ import (
 	"cosmossdk.io/client/v2/autocli/flag"
 	"cosmossdk.io/core/appmodule"
 	"cosmossdk.io/depinject"
+	"cosmossdk.io/log"
+	"cosmossdk.io/x/tx/signing"
 
 	"github.com/cosmos/cosmos-sdk/client"
 	sdkflags "github.com/cosmos/cosmos-sdk/client/flags"
+	"github.com/cosmos/cosmos-sdk/codec/types"
+	"github.com/cosmos/gogoproto/proto"
 )
 
 // AppOptions are autocli options for an app. These options can be built via depinject based on an app config. Ex:
@@ -36,8 +40,18 @@ type AppOptions struct {
 
 	// ClientCtx contains the necessary information needed to execute the commands.
 	ClientCtx client.Context
+
+	// SkipValidation is used to skip the validation of the autocli options. This is useful when
+	// constructing the options manually and not using depinject.
+	// TODO: replace custom type once `ignored` tag is available in depinject
+	// in https://github.com/cosmos/cosmos-sdk/pull/22409
+	// at the point it can be made private and ignored. i.e.
+	// skipValidation bool `ignored:"true"`
+	SkipValidation SkipValidationBool `optional:"true"`
 }
 
+type SkipValidationBool bool
+
 // EnhanceRootCommand enhances the provided root command with autocli AppOptions,
 // only adding missing commands and doesn't override commands already
 // in the root command. This allows for the graceful integration of autocli with
@@ -73,8 +87,10 @@ func (appOptions AppOptions) EnhanceRootCommand(rootCmd *cobra.Command) error {
 }
 
 func (appOptions AppOptions) EnhanceRootCommandWithBuilder(rootCmd *cobra.Command, builder *Builder) error {
-	if err := builder.ValidateAndComplete(); err != nil {
-		return err
+	if !appOptions.SkipValidation {
+		if err := builder.ValidateAndComplete(); err != nil {
+			return err
+		}
 	}
 
 	// extract any custom commands from modules
@@ -124,3 +140,46 @@ func (appOptions AppOptions) EnhanceRootCommandWithBuilder(rootCmd *cobra.Comman
 
 	return nil
 }
+
+func NewAppOptionsSkeleton(
+	modulesConfig depinject.Config,
+	moduleOptions map[string]*autocliv1.ModuleOptions,
+) (AppOptions, error) {
+	interfaceRegistry, err := types.NewInterfaceRegistryWithOptions(types.InterfaceRegistryOptions{
+		ProtoFiles: proto.HybridResolver,
+		SigningOptions: signing.Options{
+			AddressCodec:          nopAddressCodec{},
+			ValidatorAddressCodec: nopAddressCodec{},
+		},
+	})
+	if err != nil {
+		return AppOptions{}, err
+	}
+	cfg := struct {
+		depinject.In
+		Modules map[string]appmodule.AppModule
+	}{
+		Modules: nil,
+	}
+	err = depinject.Inject(depinject.Configs(
+		modulesConfig,
+		depinject.Supply(
+			log.NewNopLogger(),
+		)), &cfg)
+	if err != nil {
+		return AppOptions{}, err
+	}
+
+	return AppOptions{
+		Modules:        cfg.Modules,
+		ClientCtx:      client.Context{InterfaceRegistry: interfaceRegistry},
+		ModuleOptions:  moduleOptions,
+		SkipValidation: true,
+	}, nil
+}
+
+type nopAddressCodec struct{}
+
+func (nopAddressCodec) StringToBytes(_ string) ([]byte, error) { return nil, nil }
+
+func (nopAddressCodec) BytesToString(_ []byte) (string, error) { return "", nil }

client/v2/go.mod

@@ -23,10 +23,10 @@ require (
 require (
 	buf.build/gen/go/cometbft/cometbft/protocolbuffers/go v1.35.1-20240701160653-fedbb9acfd2f.1 // indirect
 	buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go v1.35.1-20240130113600-88ef6483f90f.1 // indirect
-	cosmossdk.io/collections v0.4.0 // indirect
+	cosmossdk.io/collections v0.4.1-0.20241104084251-838f1557af0a // indirect
 	cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 // indirect
 	cosmossdk.io/errors v1.0.1 // indirect
-	cosmossdk.io/log v1.4.1 // indirect
+	cosmossdk.io/log v1.4.1
 	cosmossdk.io/math v1.3.0
 	cosmossdk.io/schema v0.3.1-0.20241010135032-192601639cac // indirect
 	cosmossdk.io/store v1.1.1-0.20240418092142-896cdf1971bc // indirect

client/v2/go.sum

@@ -6,6 +6,8 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
 cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
 cosmossdk.io/collections v0.4.0 h1:PFmwj2W8szgpD5nOd8GWH6AbYNi1f2J6akWXJ7P5t9s=
 cosmossdk.io/collections v0.4.0/go.mod h1:oa5lUING2dP+gdDquow+QjlF45eL1t4TJDypgGd+tv0=
+cosmossdk.io/collections v0.4.1-0.20241104084251-838f1557af0a h1:9DxUD+82dO3c+R3XqwW+a7i4nVLiN6I0g2rp2rLOh7E=
+cosmossdk.io/collections v0.4.1-0.20241104084251-838f1557af0a/go.mod h1:DcD++Yfcq0OFtM3CJNYLIBjfZ+4DEyeJ/AUk6gkwlOE=
 cosmossdk.io/core v1.0.0-alpha.5 h1:McjYXAQ6XcT20v2uHyH7PhoWH8V+mebzfVFqT3GinsI=
 cosmossdk.io/core v1.0.0-alpha.5/go.mod h1:3u9cWq1FAVtiiCrDPpo4LhR+9V6k/ycSG4/Y/tREWCY=
 cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 h1:NxxUo0GMJUbIuVg0R70e3cbn9eFTEuMr7ev1AFvypdY=

simapp/v2/simdv2/cmd/root_di.go

@@ -39,6 +39,20 @@ func NewRootCmd[T transaction.Tx](
 		return nil, err
 	}
 
+	nodeCmds := nodeservice.NewNodeCommands()
+	autoCLIModuleOpts := make(map[string]*autocliv1.ModuleOptions)
+	autoCLIModuleOpts[nodeCmds.Name()] = nodeCmds.AutoCLIOptions()
+	autoCliOpts, err := autocli.NewAppOptionsSkeleton(
+		depinject.Configs(simapp.AppConfig(), depinject.Supply(runtime.GlobalConfig{})),
+		autoCLIModuleOpts,
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	if err = autoCliOpts.EnhanceRootCommand(rootCommand); err != nil {
+		return nil, err
+	}
 	subCommand, configMap, logger, err := factory.ParseCommand(rootCommand, args)
 	if err != nil {
 		if errors.Is(err, pflag.ErrHelp) {
@@ -48,7 +62,6 @@ func NewRootCmd[T transaction.Tx](
 	}
 
 	var (
-		autoCliOpts     autocli.AppOptions
 		moduleManager   *runtime.MM[T]
 		clientCtx       client.Context
 		simApp          *simapp.SimApp[T]
@@ -93,9 +106,7 @@ func NewRootCmd[T transaction.Tx](
 	if err != nil {
 		return nil, err
 	}
-	nodeCmds := nodeservice.NewNodeCommands()
-	autoCliOpts.ModuleOptions = make(map[string]*autocliv1.ModuleOptions)
-	autoCliOpts.ModuleOptions[nodeCmds.Name()] = nodeCmds.AutoCLIOptions()
+	autoCliOpts.ModuleOptions = autoCLIModuleOpts
 	if err := autoCliOpts.EnhanceRootCommand(rootCommand); err != nil {
 		return nil, err
 	}