-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare core changelog #22495
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ go 1.23.1 | |
require ( | ||
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/client/v2 v2.0.0-00010101000000-000000000000 | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
cosmossdk.io/core v1.0.0-alpha.5.0.20241108140525-43e28b43ad7a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verify the timestamp in the dependency version. The pseudo-version contains a future timestamp (20241108 = Nov 8, 2024). This might cause issues with dependency management tools. Consider using a version with a current or past timestamp to ensure compatibility with Go's dependency management system. 💡 Codebase verification Version mismatch detected across modules The codebase shows inconsistent versions of
This version mismatch could lead to compatibility issues. The following modules need to be synchronized:
🔗 Analysis chainLGTM on the core dependency update. The update to a specific pseudo-version improves reproducibility and version control. Let's verify the version compatibility: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the compatibility of the new core version across the codebase
# Test: Check for any potential version conflicts or inconsistencies
rg -g 'go.mod' "cosmossdk.io/core v1.0.0-alpha"
Length of output: 2213 |
||
cosmossdk.io/depinject v1.1.0 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/math v1.3.0 | ||
|
@@ -291,7 +291,6 @@ replace ( | |
// server v2 integration | ||
replace ( | ||
cosmossdk.io/api => ../../api | ||
cosmossdk.io/core => ../../core | ||
cosmossdk.io/core/testing => ../../core/testing | ||
cosmossdk.io/runtime/v2 => ../../runtime/v2 | ||
cosmossdk.io/server/v2 => ../../server/v2 | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,7 +3,7 @@ module cosmossdk.io/store/v2 | |||||
go 1.23 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Invalid Go version specified. The module requires Go 1.23 which hasn't been released yet. This will cause build failures as the latest stable version is Go 1.22. Apply this diff to fix the Go version: -go 1.23
+go 1.21 📝 Committable suggestion
Suggested change
|
||||||
|
||||||
require ( | ||||||
cosmossdk.io/core v1.0.0-alpha.5 | ||||||
cosmossdk.io/core v1.0.0-alpha.5.0.20241108140525-43e28b43ad7a | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Inconsistent core dependency versions detected across modules Several modules are still using
Note: Tools modules (cosmovisor, hubl, confix) use v0.11.1, which is expected as they're not part of the core update. 🔗 Analysis chainLGTM: Core dependency update aligns with changelog preparation. The update to a specific pseudo-version Let's verify this change is consistent across other modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that all modules are using the same core version
# Expected: All modules should use the same specific version of core
# Search for core dependency declarations across all go.mod files
rg "cosmossdk.io/core v" -g "go.mod"
Length of output: 2433 |
||||||
cosmossdk.io/core/testing v0.0.0-20240923163230-04da382a9f29 | ||||||
cosmossdk.io/errors/v2 v2.0.0-20240731132947-df72853b3ca5 | ||||||
cosmossdk.io/log v1.4.1 | ||||||
|
@@ -64,5 +64,3 @@ require ( | |||||
google.golang.org/protobuf v1.35.1 // indirect | ||||||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||||||
) | ||||||
|
||||||
replace cosmossdk.io/core => ../../core |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ go 1.23.1 | |
require ( | ||
cosmossdk.io/api v0.7.6 | ||
cosmossdk.io/collections v0.4.1-0.20241104084251-838f1557af0a | ||
cosmossdk.io/core v1.0.0-alpha.5 | ||
cosmossdk.io/core v1.0.0-alpha.5.0.20241108140525-43e28b43ad7a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Version inconsistency detected across modules The
This inconsistency needs to be addressed to ensure all modules are aligned with the new version. 🔗 Analysis chainLGTM! Version update aligns with changelog preparation. The update of Let's verify that this version is consistent across all dependent modules: 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for consistency of cosmossdk.io/core version across all go.mod files
# Expected: All modules should use the same version
# Find all go.mod files and check the cosmossdk.io/core version
fd --type f "go.mod" --exec grep -l "cosmossdk.io/core" {} \; | \
xargs awk '/cosmossdk\.io\/core/ && !/replace/ {print FILENAME ":" $0}'
Length of output: 5739 |
||
cosmossdk.io/depinject v1.1.0 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/math v1.3.0 | ||
|
@@ -248,7 +248,6 @@ replace ( | |
cosmossdk.io/api => ../api | ||
cosmossdk.io/client/v2 => ../client/v2 | ||
cosmossdk.io/collections => ../collections | ||
cosmossdk.io/core => ../core | ||
cosmossdk.io/core/testing => ../core/testing | ||
cosmossdk.io/indexer/postgres => ../indexer/postgres | ||
cosmossdk.io/runtime/v2 => ../runtime/v2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Future timestamp detected in dependency version
The commit timestamp
2024-11-08T14:05:25Z
in the pseudo-version is indeed from November 2024, which is in the future relative to the current development timeline. Using future timestamps in dependency versions can lead to reproducibility issues and should be avoided.cosmossdk.io/core v1.0.0-alpha.5.0.20241108140525-43e28b43ad7a
should be updated to use a version with a valid timestamp.🔗 Analysis chain
Verify the timestamp in the pseudo-version
The pseudo-version
v1.0.0-alpha.5.0.20241108140525-43e28b43ad7a
contains a timestamp from November 2024, which appears to be in the future. Please verify if this is correct.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 288