test: investigate test failure due to wal log #22679
Draft
+4
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#22577 took way longer than needed due to some logs added by the dbs.
It makes fail the systemtests on CI only (while passing locally).
This reverts the hack and investigate how to get a better fix (RunWithSingleOutput was added in #22577 but doesn't seem to work super well on CI still)
The more astonishing thing is that #22577 set the default db as goleveldb as well in simapp, so that the upgrade test keeps working, but those tests were still failing... while it is a pebbledb log line: https://github.com/cockroachdb/pebble/blob/21866e882237f27e9cfcc974b7b3031dd7543bda/open.go#L1031C9-L1031C15
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...