Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create v2 upgrading guide skeleton #22696
docs: create v2 upgrading guide skeleton #22696
Changes from 2 commits
cde85b5
64cc446
25d623a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Document server configuration parameters
The server configuration example needs explanation of each parameter.
+Parameters explained:
+*
rootCmd
: Root command of your application+*
logger
: Application logger instance+*
simApp
: Your application instance+*
deps.GlobalConfig
: Global configuration settings+*
initServerConfig()
: Server-specific configuration+*
deps.ConsensusServer
: Consensus server component+*
grpcServer
: gRPC server instance+*
storeComponent
: State store component+*
telemetryServer
: Metrics server (port 7180)+*
restServer
: REST API server (port 8080)+*
grpcgatewayServer
: gRPC-Gateway serverThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix broken link and enhance migration path
The link fragment is incorrect and the migration path needs more detail.
📝 Committable suggestion
🧰 Tools
🪛 Markdownlint (0.37.0)
62-62: null
Link fragments should be valid
(MD051, link-fragments)