Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(keyring): add keyctl docs #23563

Merged
merged 1 commit into from
Jan 30, 2025
Merged

docs(keyring): add keyctl docs #23563

merged 1 commit into from
Jan 30, 2025

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 30, 2025

Add user documentation about the relatively new keyctl backend introduced in Cosmos SDK

Supersedes cosmos/cosmos-sdk-docs#270


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Added documentation for the keyctl backend, a Linux-specific key storage option that leverages the kernel's security key management system.
  • Documentation

    • Updated keyring documentation with improved descriptions and clarity about available backend options.

Add user documentation about the relatively new keyctl backend introduced in Cosmos SDK
@alessio alessio requested a review from a team as a code owner January 30, 2025 18:02
Copy link
Contributor

coderabbitai bot commented Jan 30, 2025

📝 Walkthrough

Walkthrough

The pull request updates the documentation for the keyring system, specifically introducing the new keyctl backend. This backend is a Linux-specific key storage mechanism that utilizes the kernel's security key management system. The documentation now provides details about this new backend, explaining its functionality and platform availability. The changes focus on enhancing the documentation's clarity and comprehensiveness by incorporating information about the keyctl backend alongside existing key storage options.

Changes

File Change Summary
docs/user/run-node/00-keyring.md Added documentation for the new keyctl backend, describing its Linux-specific key storage functionality and integrating it with existing backend descriptions

Possibly related PRs

Suggested labels

C:x/accounts, C:x/accounts/lockup

Suggested reviewers

  • JulianToledano
  • sontrinh16
  • tac0turtle

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
docs/user/run-node/00-keyring.md (2)

38-39: Improve sentence structure and grammar.

The description of the keyctl backend needs grammatical improvements:

-`keyctl` is a secure backend leverages the Linux's kernel security key management system
-to store cryptographic keys securely in memory.
+`keyctl` is a secure backend that leverages the Linux kernel's security key management system
+to store cryptographic keys securely in memory.

98-105: Enhance the keyctl backend section.

The section needs some improvements:

  1. Fix punctuation:
-cryptographic data such as passwords, private key, authentication tokens, etc
+cryptographic data such as passwords, private keys, authentication tokens, etc.
  1. Consider adding:
  • Setup instructions or prerequisites (e.g., required packages)
  • Basic usage examples
  • Any specific configuration requirements

Would you like me to help generate the additional documentation content?

🧰 Tools
🪛 LanguageTool

[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...ds, private key, authentication tokens, etc to be stored securely in memory. The `...

(ETC_PERIOD)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b87acd2 and b7ad4c6.

📒 Files selected for processing (1)
  • docs/user/run-node/00-keyring.md (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/user/run-node/00-keyring.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/user/run-node/00-keyring.md

[typographical] ~37-~37: Consider isolating this adverbial phrase with commas.
Context: ...DE_Wallet_Manager). Whilst the former is in fact a libsecret convenient frontend, the ...

(IN_FACT_COMMA_2)


[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...ds, private key, authentication tokens, etc to be stored securely in memory. The `...

(ETC_PERIOD)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: build (arm64)
  • GitHub Check: build (amd64)
  • GitHub Check: markdown-link-check
  • GitHub Check: Summary
🔇 Additional comments (1)
docs/user/run-node/00-keyring.md (1)

32-32: LGTM!

The addition of keyctl to the list of GNU/Linux credential managers is appropriate and well-documented with a proper link to the kernel documentation.

@aljo242 aljo242 changed the title keyring: add keyctl docs docs(keyring): add keyctl docs Jan 30, 2025
@julienrbrt julienrbrt added backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release backport/v0.52.x labels Jan 30, 2025
@julienrbrt julienrbrt added this pull request to the merge queue Jan 30, 2025
Merged via the queue into cosmos:main with commit caebe00 Jan 30, 2025
67 of 75 checks passed
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
mergify bot pushed a commit that referenced this pull request Jan 30, 2025
julienrbrt pushed a commit that referenced this pull request Jan 31, 2025
julienrbrt pushed a commit that referenced this pull request Jan 31, 2025
alpe added a commit that referenced this pull request Jan 31, 2025
* main:
  build(deps): Bump actions/create-github-app-token from 1.11.1 to 1.11.2 (#23567)
  docs(keyring): add keyctl docs (#23563)
  chore: rm `tools/hubl` (#23562)
  build(deps): Bump github.com/spf13/pflag from 1.0.5 to 1.0.6 (#23555)
@alessio alessio deleted the patch-1 branch February 6, 2025 08:34
SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Feb 20, 2025
* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030)

* build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>

* feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540)

Co-authored-by: Julien Robert <[email protected]>

* feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554)

Co-authored-by: Julien Robert <[email protected]>

* docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566)

Co-authored-by: Alessio Treglia <[email protected]>

* docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663)

Co-authored-by: Julien Robert <[email protected]>

* chore: remove unused orm module (backport cosmos#23633) (cosmos#23637)

Co-authored-by: Zachary Becker <[email protected]>

* Merge commit from fork

* Prevent empty groups

(cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8)

* Handle inflight proposals

(cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9)

* No empty group with simulations

* Update changelog

* Set release date

* updates

* Update RELEASE_NOTES.md

* Update RELEASE_NOTES.md

---------

Co-authored-by: Alex Peters <[email protected]>
Co-authored-by: Julien Robert <[email protected]>

* Mark v0.50.12-pio-1 in the changelog.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Zachary Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants