-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(keyring): add keyctl docs #23563
Conversation
Add user documentation about the relatively new keyctl backend introduced in Cosmos SDK
📝 WalkthroughWalkthroughThe pull request updates the documentation for the keyring system, specifically introducing the new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/user/run-node/00-keyring.md (2)
38-39
: Improve sentence structure and grammar.The description of the
keyctl
backend needs grammatical improvements:-`keyctl` is a secure backend leverages the Linux's kernel security key management system -to store cryptographic keys securely in memory. +`keyctl` is a secure backend that leverages the Linux kernel's security key management system +to store cryptographic keys securely in memory.
98-105
: Enhance the keyctl backend section.The section needs some improvements:
- Fix punctuation:
-cryptographic data such as passwords, private key, authentication tokens, etc +cryptographic data such as passwords, private keys, authentication tokens, etc.
- Consider adding:
- Setup instructions or prerequisites (e.g., required packages)
- Basic usage examples
- Any specific configuration requirements
Would you like me to help generate the additional documentation content?
🧰 Tools
🪛 LanguageTool
[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...ds, private key, authentication tokens, etc to be stored securely in memory. The `...(ETC_PERIOD)
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/user/run-node/00-keyring.md
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
docs/user/run-node/00-keyring.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
docs/user/run-node/00-keyring.md
[typographical] ~37-~37: Consider isolating this adverbial phrase with commas.
Context: ...DE_Wallet_Manager). Whilst the former is in fact a libsecret
convenient frontend, the ...
(IN_FACT_COMMA_2)
[style] ~102-~102: In American English, abbreviations like “etc.” require a period.
Context: ...ds, private key, authentication tokens, etc to be stored securely in memory. The `...
(ETC_PERIOD)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: build (arm64)
- GitHub Check: build (amd64)
- GitHub Check: markdown-link-check
- GitHub Check: Summary
🔇 Additional comments (1)
docs/user/run-node/00-keyring.md (1)
32-32
: LGTM!The addition of
keyctl
to the list of GNU/Linux credential managers is appropriate and well-documented with a proper link to the kernel documentation.
(cherry picked from commit caebe00)
(cherry picked from commit caebe00)
Co-authored-by: Alessio Treglia <[email protected]>
Co-authored-by: Alessio Treglia <[email protected]>
* build(deps): Bump github.com/cosmos/cosmos-db from 1.1.0 to 1.1.1 (cosmos#23030) * build(deps): Bump github.com/cosmos/ledger-cosmos-go from 0.13.3 to 0.14.0 (cosmos#23029) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/tx): add an option to encode maps using amino json (backport cosmos#23539) (cosmos#23540) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): add map support (backport cosmos#23544) (cosmos#23554) Co-authored-by: Julien Robert <[email protected]> * docs(keyring): add keyctl docs (backport cosmos#23563) (cosmos#23566) Co-authored-by: Alessio Treglia <[email protected]> * docs: correct explanation on how to set custom signer via depinject (backport cosmos#23654) (cosmos#23663) Co-authored-by: Julien Robert <[email protected]> * chore: remove unused orm module (backport cosmos#23633) (cosmos#23637) Co-authored-by: Zachary Becker <[email protected]> * Merge commit from fork * Prevent empty groups (cherry picked from commit 95090a0ec1f193104ba7d6d033a490d1515e54d8) * Handle inflight proposals (cherry picked from commit 855983471882068894ed7952b592ab3e61b464b9) * No empty group with simulations * Update changelog * Set release date * updates * Update RELEASE_NOTES.md * Update RELEASE_NOTES.md --------- Co-authored-by: Alex Peters <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Mark v0.50.12-pio-1 in the changelog. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Zachary Becker <[email protected]>
Add user documentation about the relatively new keyctl backend introduced in Cosmos SDK
Supersedes cosmos/cosmos-sdk-docs#270
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
keyctl
backend, a Linux-specific key storage option that leverages the kernel's security key management system.Documentation