Skip to content

Commit

Permalink
Merge branch 'main' into feat/sdk-47-ibc-7
Browse files Browse the repository at this point in the history
  • Loading branch information
sainoe committed Jan 12, 2024
2 parents 1c4c653 + 536a617 commit 6146536
Show file tree
Hide file tree
Showing 16 changed files with 136 additions and 124 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: "go"
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -44,7 +44,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -58,4 +58,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
2 changes: 1 addition & 1 deletion .github/workflows/docker-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- name: Extract metadata (tags, labels) for Docker
id: meta
uses: docker/metadata-action@v5.3.0
uses: docker/metadata-action@v5.5.0
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
if: env.GIT_DIFF
run: |
go test -v -coverprofile=profile.out -covermode=atomic -coverpkg=./... $(go list ./... | grep -v -e '/tests/e2e')
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: env.GIT_DIFF
with:
name: "${{ github.sha }}-coverage"
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
go.sum
**/go.mod
**/go.sum
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
if: env.GIT_DIFF
with:
name: "${{ github.sha }}-coverage"
Expand Down
1 change: 1 addition & 0 deletions docs/governance/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Governance discussions happens in a number of places moderated by diverse commun

- [Forum](http://forum.cosmos.network/)
- [Discord](https://discord.com/invite/cosmosnetwork)
<!-- markdown-link-check-disable-next-line -->
- [Twitter](https://twitter.com/CosmosGov)
- [Reddit](http://reddit.com/r/cosmosnetwork)
- anywhere else you might interact with members of the Cosmos community!
3 changes: 3 additions & 0 deletions docs/governance/best-practices.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ You'll first want to determine which kind of proposal you are making. Be sure to

Engagement is likely to be critical to the success of a proposal. The degree to which you engage with the Cosmos Hub community should be relative to the potential impact that your proposal may have on the stakeholders. This guide does not cover all ways of engaging but here are some suggestions:
- Post your idea to the [Cosmos Hub Forum](https://forum.cosmos.network/)
<!-- markdown-link-check-disable-next-line -->
- Mention the idea in a community call (often hosted on [Twitter](https://twitter.com/CosmosHub))
- Host an AMA on [Reddit](https://www.reddit.com/r/cosmosnetwork)

Expand Down Expand Up @@ -139,6 +140,7 @@ This Markdown-formatted post can eventually become the description text in a pro

2. Directly engage key members of the community for feedback. These could be large contributors, those likely to be most impacted by the proposal, and entities with high stake-backing (eg. high-ranked validators; large stakers).

<!-- markdown-link-check-disable-next-line -->
3. Alert the entire community to the draft proposal on other platforms such as Twitter, tagging accounts such as the [Cosmos Hub account](https://twitter.com/cosmoshub), the [Cosmos Governance account](https://twitter.com/CosmosGov), and other governance-focused groups.

### Submit your proposal to the testnet
Expand All @@ -159,6 +161,7 @@ The deposit period currently lasts 14 days. If you submitted your transaction wi

This is a stage where proposals may begin to get broader attention. Some block explorers display proposals in the deposit period, while others don't show them until they hit voting period.

<!-- markdown-link-check-disable-next-line -->
A large cross-section of the blockchain/cryptocurrency community exists on Twitter. Having your proposal in the deposit period is a good time to engage the so-called 'crypto Twitter' Cosmos community to prepare validators to vote (eg. tag [@cosmosvalidator](https://twitter.com/cosmosvalidator)) and ATOM-holders that are staking (eg. tag [@cosmoshub](https://twitter.com/cosmoshub), [@CosmosGov](https://twitter.com/CosmosGov)).

### The Voting Period
Expand Down
2 changes: 1 addition & 1 deletion docs/governance/proposal-types/text-prop.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The process for these historical proposals was that an on-chain signal was used
## Why make a signaling proposal?
Signaling proposals are a great way to take an official, public poll of community sentiment before investing more resources into a project. The most common way for text proposals to be used is to confirm that the community is actually interested in what the proposer wants to develop, without asking for money to fund development that might not be concrete enough to have a budget yet.

Because the results of signaling proposals remain on-chain and are easily accessible to anyone, they are also a good way to formalize community opinions. Information contained in documentation or Github repo's can be hard to find for new community members but signaling proposals in a block explorer or wallet is very accessible.
Because the results of signaling proposals remain on-chain and are easily accessible to anyone, they are also a good way to formalize community opinions. Information contained in documentation or Github repos can be hard to find for new community members but signaling proposals in a block explorer or wallet is very accessible.

You might make a signaling proposal to gather opinions for work you want to do for the Hub, or because you think it's important to have a record of some perspective held by the community at large.

Expand Down
6 changes: 3 additions & 3 deletions docs/governance/proposals/2020-10-blocks-per-year/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ wiki](https://github.com/cosmos/governance/blob/master/params-change/Mint.md).
In this proposal we will be looking at adjusting the blocks per year parameter.

Currently the variable named “blocks per year” is set at 4,855,015. This works
out to one block every 6.5 second roughly, which as many Atom holders know, is
out to one block every 6.5 seconds roughly, which as many Atom holders know, is
not a very good approximation. This leads to the stated inflation rate of the
cosmos hub to not match reality.

Expand Down Expand Up @@ -45,7 +45,7 @@ per year**.
I will split this up into two sections, doing nothing & doing the proposed
changes.

1a) Doing nothing Risks / Benefits: There are no structural risks per say doing
1a) Doing nothing Risks / Benefits: There are no structural risks per se doing
nothing, but the stated inflation rate of the hub will continue to not match
reality. There are very little benefits of doing nothing; besides the fact its
working just fine now as long as you don’t care how close stated inflation is vs
Expand All @@ -67,4 +67,4 @@ to be fine tuned over the coming years / decades. This seems like a very good
starting place and a greatly beneficial change before we enter the post star
gate world ☺

<!-- markdown-link-check-enable -->
<!-- markdown-link-check-enable -->
4 changes: 2 additions & 2 deletions docs/governance/proposals/proposal-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
## Context

> A complete, yet brief account of the current sitation the proposal aims to address. It should clear explain the motivation, goals, and expected outcomes of the proposal as well as how the proposal addresses the situation better than other options.
> A complete, yet brief account of the current situation the proposal aims to address. It should clearly explain the motivation, goals, and expected outcomes of the proposal as well as how the proposal addresses the situation better than other options.
## Governance Votes

The following items summarize the voting options and what it means for this proposal.

- **YES**: You approve the {type} proposal to...{one sentence summary}.
- **NO**: You disapprove of the proposal in its current form. The NO vote can be a request for improvements or adjustments, please indicated them in the relevant topic in the [Cosmos forum](https://forum.cosmos.network/). You agree that this proposal's motivation is valuable and that the team should create a follow-up proposal once the amendments are included.
- **NO**: You disapprove of the proposal in its current form. The NO vote can be a request for improvements or adjustments, please indicate them in the relevant topic in the [Cosmos forum](https://forum.cosmos.network/). You agree that this proposal's motivation is valuable and that the team should create a follow-up proposal once the amendments are included.
- **NO (VETO)**: You veto the entire motivation for the proposal, are strongly opposed to its implementation, and will exit the network if passed. You are signalling the proposers should not create a follow-up proposal.
- **ABSTAIN**: You are impartial to the outcome of the proposal.

Expand Down
2 changes: 1 addition & 1 deletion docs/hub-tutorials/upgrade-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ If you are running a **validator node** on the mainnet, always be careful when d
:::

::: danger IMPORTANT
Make sure that every node has a unique `priv_validator.json`. Do not copy the `priv_validator.json` from an old node to multiple new nodes. Running two nodes with the same `priv_validator.json` will cause you to get slashed due to double sign !
Make sure that every node has a unique `priv_validator.json`. Do not copy the `priv_validator.json` from an old node to multiple new nodes. Running two nodes with the same `priv_validator.json` will cause you to get slashed due to double signing!
:::

First, remove the outdated files and reset the data. **If you are running a validator node, make sure you understand what you are doing before resetting**.
Expand Down
4 changes: 2 additions & 2 deletions docs/resources/genesis.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ Let us break down the parameters:
- `original_vesting`: Vesting is natively supported by `gaia`. You can define an amount of token owned by the account that needs to be vested for a period of time before they can be transferred. Vested tokens can be delegated. Default value is `null`.
- `delegated_free`: Amount of delegated tokens that can be transferred after they've been vested. Most of the time, will be `null` in genesis.
- `delegated_vesting`: Amount of delegated tokens that are still vesting. Most of the time, will be `null` in genesis.
- `start_time`: Block at which the vesting period starts. `0` most of the time in genesis.
- `end_time`: Block at which the vesting period ends. `0` if no vesting for this account.
- `start_time`: Timestamp at which the vesting period starts. `0` most of the time in genesis.
- `end_time`: Timestamp at which the vesting period ends. `0` if no vesting for this account.

### Bank

Expand Down
2 changes: 1 addition & 1 deletion docs/resources/ledger.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ title: Ledger Support

# Ledger Nano Support

Using a hardware wallet to store your keys greatly improves the security of your crypto assets. The Ledger device acts as an enclave of the seed and private keys, and the process of signing transaction takes place within it. No private information ever leaves the Ledger device. The following is a short tutorial on using the Cosmos Ledger app with the Gaia CLI or the [Keplr](https://www.keplr.app/) wallet extension.
Using a hardware wallet to store your keys greatly improves the security of your crypto assets. The Ledger device acts as an enclave of the seed and private keys, and the process of signing transactions takes place within it. No private information ever leaves the Ledger device. The following is a short tutorial on using the Cosmos Ledger app with the Gaia CLI or the [Keplr](https://www.keplr.app/) wallet extension.

At the core of a Ledger device there is a mnemonic seed phrase that is used to generate private keys. This phrase is generated when you initialize your Ledger. The mnemonic is compatible with Cosmos and can be used to seed new accounts.

Expand Down
2 changes: 1 addition & 1 deletion docs/validators/kms/kms_ledger.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ chain_ids = ["gaia-11001"]

- Edit `addr` to point to your `gaiad` instance.
- Adjust `chain-id` to match your `.gaia/config/config.toml` settings.
- `provider.ledgertm` has not additional parameters at the moment, however, it is important that you keep that header to enable the feature.
- `provider.ledgertm` has no additional parameters at the moment, however, it is important that you keep that header to enable the feature.

*Plug your Ledger device and open the Tendermint validator app.*

Expand Down
2 changes: 1 addition & 1 deletion docs/validators/security.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Validators are responsible for ensuring that the network can sustain denial of s

One recommended way to mitigate these risks is for validators to carefully structure their network topology in a so-called sentry node architecture.

Validator nodes should only connect to full-nodes they trust because they operate them themselves or are run by other validators they know socially. A validator node will typically run in a data center. Most data centers provide direct links the networks of major cloud providers. The validator can use those links to connect to sentry nodes in the cloud. This shifts the burden of denial-of-service from the validator's node directly to its sentry nodes, and may require new sentry nodes be spun up or activated to mitigate attacks on existing ones.
Validator nodes should only connect to full-nodes they trust because they operate them themselves or are run by other validators they know socially. A validator node will typically run in a data center. Most data centers provide direct links to the networks of major cloud providers. The validator can use those links to connect to sentry nodes in the cloud. This shifts the burden of denial-of-service from the validator's node directly to its sentry nodes, and may require new sentry nodes be spun up or activated to mitigate attacks on existing ones.

Sentry nodes can be quickly spun up or change their IP addresses. Because the links to the sentry nodes are in private IP space, an internet based attack cannot disturb them directly. This will ensure validator block proposals and votes always make it to the rest of the network.

Expand Down
Loading

0 comments on commit 6146536

Please sign in to comment.