ci: interchain tests for cosmwasm, plus IBC & jailing on consumer chains #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fastfadingviolets
requested review from
dasanchez,
LexaMichaelides and
a team
as code owners
dasanchez
approved these changes
Aug 19, 2024
stana-miric
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
LGTM
I have a small suggestion regarding the module name. It would be better to remove the version (v20) from the middle of the module path(module github.com/cosmos/gaia/v20/tests/interchain). Having the version in the middle makes the module name invalid according to Go's module naming conventions and causes issues when trying to import this module into other projects, as it treats interchain as a subpackage of gaia.
Not mandatory to change it but it would be good just in case if we decide to reuse this setup in ics tests
|
will do @stana-miric i'll add that to a future PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Porting some of Hypha's tests into gaia. These have basic permissioned cosmwasm, plus IBC transactions, and tests for validator jailing on consumer chains
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...