User recovery mechanism for non-refundable forwards #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip: add dummy middleware to modify packets * rm unused * force inFlightPacket.Nonrefundable = true * dummyware.AppModuleBasic * test: create non-refundable pfm test cases * Get source originating tests passing * remove parallel * lint * fix test, update comments * fix final test --------- Co-authored-by: Justin Tieri <[email protected]> Co-authored-by: Andrew Gouin <[email protected]>
Reecepbcups
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if non-refundable is set (swap-n-forward middleware is the only use case of this we know of), and a forward after a point of no return fails (due to max timeouts or ack error), the funds end up stuck in the escrow account. This does not give the user a way to recover their funds in that scenario.
This introduces a mechanism in that scenario to move the funds from the escrow account: