fix: only use relative timeout timestamps in ica cli #7961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
|
Needs changelog. Can include in v8.5.4 @gjermundgaraba edit: actually I think this diff is not in v8.x so only in v9+ |
gjermundgaraba
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Noice! Thanks @damiannolan <3 I added a changelog entry to the PR as well :)
|
Thank you @gjermundgaraba! |
10 tasks
yihuang
reviewed
Feb 13, 2025
| if !absoluteTimeouts { | ||
| if timeoutTimestamp == 0 { | ||
| return errors.New("relative timeouts must provide a non zero value timestamp") | ||
| } |
There was a problem hiding this comment.
should we keep this zero check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This slipped in at some point in the past to attempt to use absolute timeouts in the ica
sendTxcli.This is incorrect as the within the state machine an absolute timeout is calculated by adding the provided value to the current block time.
ref: https://github.com/cosmos/ibc-go/blob/main/modules/apps/27-interchain-accounts/controller/keeper/msg_server.go#L72-L75
cc. @yihuang
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.