refactor: VerifyMembership and VerifyNonMembership api #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
running into a bit of import issues as this fn is depended on by cosmos/iavl, cosmos/cosmos-sdk, and cosmos/ibc-go. Might be good to see what the update flow is before merging |
colin-axner
commented
Oct 21, 2024
colin-axner
commented
Oct 21, 2024
go/ics23.go
Outdated
| return ep | ||
| } | ||
| } | ||
| if !isLeft(spec, np.Left, key) || !isRight(spec, np.Right, key) { |
There was a problem hiding this comment.
maybe this check should be within NonExistenceProof.Verify?
10 tasks
…thub.com:cosmos/ics23 into colin/update-verify-membership-and-nonmembership
colin-axner
commented
Oct 21, 2024
| switch p := proof.Proof.(type) { | ||
| case *CommitmentProof_Exist: | ||
| ep := p.Exist | ||
| if bytes.Equal(ep.Key, key) { |
There was a problem hiding this comment.
checked in ep.Verify
colin-axner
commented
Oct 21, 2024
| switch p := proof.Proof.(type) { | ||
| case *CommitmentProof_Nonexist: | ||
| np := p.Nonexist | ||
| if isLeft(spec, np.Left, key) && isRight(spec, np.Right, key) { |
There was a problem hiding this comment.
checked in np.Verify
AdityaSripal
approved these changes
Oct 22, 2024
damiannolan
approved these changes
Oct 23, 2024
…rify-membership-and-nonmembership
colin-axner
deleted the
colin/update-verify-membership-and-nonmembership
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #389