Feat/swap #131
Merged
Feat/swap #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chcmedeiros
commented
Dec 20, 2024
chcmedeiros
commented
- update zxlib
- add support for swap feature (bumped minor)
chcmedeiros
force-pushed
the
feat/swap
branch
from
b840301 to
6fb9ed6
Compare
emmanuelm41
approved these changes
Dec 20, 2024
|
|
||
| jobs: | ||
| job_functional_tests: | ||
| uses: Zondax/app-exchange/.github/workflows/reusable_swap_functional_tests.yml@swap-cosmos |
There was a problem hiding this comment.
We should set the LedgerHQ version before merging this PR
| with: | ||
| branch_for_polkadot: ${{ github.ref }} | ||
| repo_for_polkadot: ${{ github.repository }} | ||
| test_filter: '"Atom or atom or Cosmos or cosmos"' |
There was a problem hiding this comment.
Is this correct? Sounds weird hahaha
| } | ||
|
|
||
| // Ensure the received transaction matches what was validated in the Exchange app UI | ||
| // at this poin, transaction was parsed by the app,so we need to compare what we aprsed with what is saved in the global state |
emmanuelm41
reviewed
Dec 20, 2024
| - master | ||
| - main | ||
| - develop | ||
| - swap |
There was a problem hiding this comment.
We should remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.